New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(efb): Simrate and Pause at T/D in EFB Quick Settings #8641
base: master
Are you sure you want to change the base?
Conversation
Still needs localisation keys, to be added before merging |
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TodGuidance.ts
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TodGuidance.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's just check package.json formatting before merging, but not relevant for testing.
Will fix EDIT: and done |
I think the simrate box needs UI improvements. At the moment it doesn't align with anything. The clock is neither in the middle of the box nor below the gap between the simbridge and keyboard button. I suggest centering the clock and displaying the next simrate in the buttons instead of the chevrons. So if you're at normal simrate, the "previous" button (i.e. decrease) button is disabled. At 4x simrate the left button reads The current simrate could be displayed as part of the box title, meaning below the clock. E.g. |
UI improvements will probably need to be in another PR at this stage, I don't anticipate having the bandwidth to adjust it further in the next 2 months. Potentially a good first issue for new contributors. |
Fixes #[issue_no]
Summary of Changes
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Pause on TOD Tests:
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.