New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cpp framework improvements and additions #8640
Open
frankkopp
wants to merge
14
commits into
flybywiresim:master
Choose a base branch
from
frankkopp:cpp-framework-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: cpp framework improvements and additions #8640
frankkopp
wants to merge
14
commits into
flybywiresim:master
from
frankkopp:cpp-framework-improvements
+2,370
−1,086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hwk
requested changes
May 3, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🔴 Code Review: In progress
May 3, 2024
Just some early comments, looking good so far. |
2hwk
moved this from 🔴 Code Review: In progress
to 🟡 Code Review: Ready for Review
in Quality Assurance
May 9, 2024
frankkopp
added
Needs Code Review
and removed
Not Ready For Review
Still draft but needs a GitHub build
labels
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
General additions and improvements to the cpp framework.
Discord username (if different from GitHub): cdr_maverick
Testing instructions
Potentially Pushback, Lighting Presets, Aircraft Presets might be impacted by these changes.
Mainly Pushback (b/o the DampingController refactor).
Other side effects unlikely.
A32NX: see above - test for regression
A380X: see above - test for regression
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.