Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cpp framework improvements and additions #8640

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Apr 30, 2024

Summary of Changes

General additions and improvements to the cpp framework.

  • added arinc library
  • added Google Test GTest framework
  • added unit tests for cpp libraries
  • refactored InterialDampener to a general DampingController
  • additional clang format to better align code for multiple assignment statements
  • gitignore cleanup

Discord username (if different from GitHub): cdr_maverick

Testing instructions

Potentially Pushback, Lighting Presets, Aircraft Presets might be impacted by these changes.
Mainly Pushback (b/o the DampingController refactor).
Other side effects unlikely.

A32NX: see above - test for regression
A380X: see above - test for regression

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@frankkopp frankkopp self-assigned this Apr 30, 2024
@frankkopp frankkopp added the Not Ready For Review Still draft but needs a GitHub build label Apr 30, 2024
@frankkopp frankkopp marked this pull request as ready for review April 30, 2024 17:09
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Apr 30, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🔴 Code Review: In progress May 3, 2024
@2hwk
Copy link
Member

2hwk commented May 3, 2024

Just some early comments, looking good so far.

@2hwk 2hwk moved this from 🔴 Code Review: In progress to 🟡 Code Review: Ready for Review in Quality Assurance May 9, 2024
@frankkopp frankkopp added Needs Code Review and removed Not Ready For Review Still draft but needs a GitHub build labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Quality Assurance
🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants