chore: adapt rust build to SU15 #8627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saschl
changed the title
2hwk
added
SU15
QA Tier 1
Not Ready For Testing
2hwk
approved these changes
Apr 20, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🟣 QA Team Review: Ready to Test
Apr 20, 2024
2hwk
moved this from 🟣 QA Team Review: Ready to Test
to ⌛ Awaiting Actions
in Quality Assurance
Does not work with standard llvm, seems to be a custom option by asobo that only works with the wasm-ld.exe from the msfs-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Updates rust build to align with SU15 changes.
Instead of using the provided libc of the rust target we link against the MSFS_SDK version as it contains some differences to the official version. Visible changes are the availability of the memory debug window in the sim and the removal of warnings in the console.
Only to be merged after dev-env update and SU15 release.
Screenshots (if necessary)
References
https://github.com/rust-lang/rust/blob/00ed4edb44ccc76d8cc992ef9f9f4634ea6d0e82/compiler/rustc_target/src/spec/targets/wasm32_wasip1.rs#L29
https://doc.rust-lang.org/rustc/codegen-options/index.html#link-self-contained
https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.