Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Plugged-Window mesh added #8357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Henrik2k17
Copy link
Contributor

Summary of Changes

Adds the ability to plug windows (livery specific).

Screenshots

FlightSimulator_9G3Kv3QxOw copy

References

88823_1638892616

Testing instructions

-Only the FBW house livery should have the first two rows plugged.
-Make sure 3rd party liveries are displayed correct (no plugs).
-Make sure the custom plugging works.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance Dec 30, 2023
@tracernz
Copy link
Member

It would be better to add this in the blender project for the fuselage I think. Do you have a blend file?

@Benjozork
Copy link
Member

We should probably document this on our docs as well

@TJCAviation
Copy link

TJCAviation commented Feb 16, 2024

I would reccomend making the Plug COMP the exact same as the Fuse COMP

With the Plug COMP being full red, it can cause some issues with the lighting/shadows as the base comp is slightly different around it...so the plugs tend to be a bit brighter then the fuse with in a shadow.

See my attatched image on the overwing exits for what I mean
FlightSimulator 2024-02-16 02-05-21

@tracernz
Copy link
Member

We need to get the blend file and png textures for this so we can integrate into our new model build.

@tracernz
Copy link
Member

Can this texture be a 2x2, transparent one by default? I don't think it's worth a bunch of VRAM for the tiny number of liveries that will use it.

@2hwk 2hwk added the Waiting For Response This issue or PR needs a response from the author label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting For Response This issue or PR needs a response from the author
Projects
Quality Assurance
🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants