Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix HelmRelease default value for .spec.upgrade.crds #986

Merged
merged 2 commits into from
May 25, 2024

Conversation

sestegra
Copy link
Contributor

In the HelmRelease documentation, the default value for .spec.upgrade.crds is set as None in Upgrade configuration part, then the default value is set as Skip in Controlling the lifecycle of Custom Resource Definitions part.

Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x labels May 24, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sestegra 🥇

PS. Please rebase

@sestegra
Copy link
Contributor Author

@stefanprodan Update done

@stefanprodan stefanprodan merged commit bd7e561 into fluxcd:main May 25, 2024
6 checks passed
@fluxcdbot
Copy link
Member

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

@stefanprodan
Copy link
Member

Ah I haven't noticed the merge commit... @souleb we need to figure out a way to block users from doing this.

@sestegra
Copy link
Contributor Author

Sorry for the extra manual labor, I owe you a drink
I found some open discussions about this issue, but no solutions found yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants