feat: Add option to uninstall a HelmRelease even if it is suspended #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
dippynark
force-pushed
the
allow-uninstall-when-suspended
branch
from
2340d98
to
5d85f0d
Compare
dippynark
changed the title
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
dippynark
force-pushed
the
allow-uninstall-when-suspended
branch
from
2d27ab2
to
07347ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the Flux kustomize-controller and helm-controller to apply configuration to clusters. Before we make changes to HelmReleases and the ConfigMaps/Secrets that they reference we suspend all of the HelmReleases; this is so that the helm-controller doesn't try to upgrade a chart before all of the configuration is in place as this may make unexpected changes depending on the order the configuration is updated. Once the HelmRelease has been updated (via the kustomize-controller) and all of the other configuration is in place we unsuspend all the HelmReleases and wait for them to reconcile.
The issue we have is that if a HelmRelease is removed from an Kustomization (e.g. when rolling back a change) the HelmReleases are suspended and do not uninstall, leaving orphaned resources. To fix this, this PR adds an option to uninstall a HelmRelease even if it is suspended.