Prototype for frozen canaries. #1196
Conversation
| return | ||
| } | ||
| } else { | ||
| canaryWeight = c.totalWeight(cd) |
There was a problem hiding this comment.
I don't understand the reasoning behind this. Why would we want to set .status.canaryWeight to 100, when it's not actually receiving 100% of the traffic?
| if err := meshRouter.SetRoutes(cd, primaryWeight, canaryWeight, false); err != nil { | ||
| c.recordEventWarningf(cd, "%v", err) | ||
| return | ||
| if !cd.Spec.Analysis.FreezeOnFailure { |
There was a problem hiding this comment.
Why restart only when FreezeOnFailure is disabled? Even, if FreezeOnFailue is true and the canary deployment changed, I think we'd want the canary analysis to restart.
| @@ -834,7 +847,8 @@ func (c *Controller) checkCanaryStatus(canary *flaggerv1.Canary, canaryControlle | |||
|
|
|||
| func (c *Controller) hasCanaryRevisionChanged(canary *flaggerv1.Canary, canaryController canary.Controller) bool { | |||
| if canary.Status.Phase == flaggerv1.CanaryPhaseProgressing || | |||
| canary.Status.Phase == flaggerv1.CanaryPhaseWaitingPromotion { | |||
| canary.Status.Phase == flaggerv1.CanaryPhaseWaitingPromotion || | |||
There was a problem hiding this comment.
I don't think we need to check for CanaryPhaseFrozen, because of the concern described in the above comment.
|
@pjotre86 thanks for this PR! Could you please add e2e tests and sign off your commits? You can refer to this test in order to understand how to write the e2e test. |
|
Hey @aryan9600 ! |
This is a prototype for #1186.