New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gloo-Mesh Support #1165
base: main
Are you sure you want to change the base?
Gloo-Mesh Support #1165
Conversation
bba5371
to
1669c9a
Compare
@rinormaloku please signoff your commits and rebase with main instead of merge. Thanks! |
d4e53d9
to
a2c50e7
Compare
Signed-off-by: rinormaloku <rinormaloku37@gmail.com>
a2c50e7
to
5a12d7b
Compare
Hi @stefanprodan, The PR is ready for review! |
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 54.73% 54.67% -0.07%
==========================================
Files 81 82 +1
Lines 6948 7117 +169
==========================================
+ Hits 3803 3891 +88
- Misses 2550 2616 +66
- Partials 595 610 +15
Continue to review full report at Codecov.
|
Signed-off-by: rinormaloku <rinormaloku37@gmail.com>
@stefanprodan is anything that I can help, for us to make progress with this PR? |
@rinormaloku this looks good, we're working on the next patch release for Flagger then we'll review your PR. I expect this to be included in the next minor release. |
Sounds good! :)) |
You need to add gloomesh to the e2e test suite here https://github.com/fluxcd/flagger/blob/main/.github/workflows/e2e.yaml |
@stefanprodan I didn't add it to the e2e suite as Gloo Mesh requires a license and currently and it would require rotating the license frequently |
@stefanprodan any update on this |
@rinormaloku @mrajkarnikar in the past we've rejected integrations with non OSS tools like Kong ingress. Having this integration in Flagger with no means of testing it automatically is not something that I would consider. |
If we provide a secret, would you be able to securely store it and make it available to the script as an Environment Variable? |
Using secrets in tests means we can no longer run them on PRs. If someone breaks this integration, we can't tell until we merge the PR when it's too late. The whole purpose of testing is to validate the changes before they get merged. Also what happens when they key expires? |
@stefanprodan so flagger will never integrate with non oss tool? Should we be closing this PR then? |
Support for Gloo Mesh 2.0