change canary status to Progressing when firstly call rollout hook succeeded #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first time call hook succeeded Signed-off-by: Shirley Ding <yingd1206@gmail.com>
ShirleyDing
force-pushed
the
fix-canary-status
branch
from
d5a3f98
to
8e3af4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when firstly call rollout hook succeeded, current canary status is Initializing, it won't be changed to Progressing, finally, in function checkCanaryStatus, Canary status will be changed to Initialized and no longer be scheduled to do traffic shift until the CanaryVersion changed. In fact, the first time rollout hook return true, we should change Canary status from Initializing to Progressing, so it can continue to do traffic shift in the next steps.