libsubprocess: minor cleanup #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
libsubprocess_minor_cleanups
branch
from
5372b1c
to
7b538a6
Compare
|
@Mergifyio rebase |
Problem: A comment cut and paste did not get updated for the actual code it was commenting on. Update the comment for the code.
Problem: Some comments still reference flux_exec(), which was renamed a long time ago. Update the comments to mention flux_local_exec().
Problem: A message in a test was not changed after a likely cut and paste. Correct test description.
Problem: A number of tests in test/remote.c output test descriptions based on the command executed in the subprocess. However, multiple tests are run under "/bin/sh", making those test descriptions duplicated across multiple tests. It'd be nice if these test descriptions could be differentiated. To differentiate the tests, instead specify a "prefix" parameter that will be output before a collection of tests. The prefix can be set to something unique to differentiate tests.
Problem: The test utility libsubprocess/test/test_echo doesn't have any usage instructions. Add some comments at the top of the file to help developers remember how this tool works.
Problem: For some reason a string is put into a buffer with sprintf before it is used. There is no other formatting of the string in any way. Remove the unnecessary buffer and sprintf call.
Problem: No coverage exists for invalid flags passed to flux_rexec(). Add a test in test/remote.c.
✅ Branch has been successfully rebased |
chu11
force-pushed
the
libsubprocess_minor_cleanups
branch
from
7b538a6
to
3756556
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5974 +/- ##
==========================================
+ Coverage 83.28% 83.30% +0.02%
==========================================
Files 515 515
Lines 83399 83399
==========================================
+ Hits 69458 69479 +21
+ Misses 13941 13920 -21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splicing out this collection of minor things from my bigger PR