flux-resource: support new "watch" subcommand #5395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had a chance to check this out, but FWIW I like the idea. Good use case for KVS watch too IMO. Nice. |
chu11
changed the title
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
0813d4b
to
2cc69cf
Compare
|
re-based, updating the changes to |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
2cc69cf
to
47e1409
Compare
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
47e1409
to
4549343
Compare
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
2 times, most recently
from
43ebdcb
to
6c51610
Compare
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
6c51610
to
9983479
Compare
|
rebased, now that #5389 is in |
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
9983479
to
af48db2
Compare
Problem: Usually a subcommand function is set at the end of the arguments, but for a few subcommands it is set earlier in the command line option parser setup. This makes anal retentive people go cuckoo. Solution: Setup the subcommand function at the end of the command line option setup consistently.
Problem: It would be nice to see resource changes as they happen in real time. Solution: Support a watch subcommand in flux-resource. The subcommand will output all online/offline/drain/undrain changes as they occur by watching resource.eventlog. Fixes flux-framework#4792
Problem: There is no coverage for the new "flux resource watch" subcommand. Add coverage in new test file t2353-resource-cmd-watch.t.
Problem: The new flux resource watch subcommand is not documented. Add documentation in flux-resource.rst.
chu11
force-pushed
the
issue4792_flux_resource_stream_changes
branch
from
af48db2
to
db512f9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5395 +/- ##
==========================================
- Coverage 83.46% 83.44% -0.02%
==========================================
Files 486 486
Lines 82933 82971 +38
==========================================
+ Hits 69217 69237 +20
- Misses 13716 13734 +18
|
|
was rebasing some old PRs, due to 42852ea, this PR / feature no longer works / makes sense. This was a "neat" feature, but mostly was done as a way to use the new kvs async watcher. If we really want this feature in the future, we'd have to do it an alternate way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #5389. Per a random idea I once had in #4792, support a
flux resource watchcommand that watches and outputs resource changes as they occur by watchingresource.eventlog. The idea is to type it in your terminal when you leave work, and see what changed in your terminal when you get back in the next day. Sample output:This was largely an exercise to make sure the recently added KVSWatch support in the Python kvs module is sorta useful. And for the most part it works as intended. Admittedly this is sort of just "neat" rather than a "must have" or "important". But went ahead and add tests/documentation just in case people like it.
Some thoughts:
should
job.EventLogEventbe moved outside ofjob/event.pyto a more general location? I didn't do that here, but for consideration.I only support the options
--alland--ranksfor now. An infinite number of output possibilities exist, but I think this is ok for now.