add libabigail checks #5062
Open
add libabigail checks #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: ABI breaks can happen between versions Solution: run libabigail against release vs. pr Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #5062 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 445 445
Lines 76577 76577
==========================================
- Hits 63688 63682 -6
- Misses 12889 12895 +6 |
grondo
reviewed
Apr 5, 2023
| docker run --rm \ | ||
| --workdir=$(pwd) \ | ||
| --volume=/tmp/libs:/tmp/libs \ | ||
| fluxrm/flux-sched:focal \ |
There was a problem hiding this comment.
This is great!
I'm sure there is a good reason, but why use the flux-sched docker image instead of flux-core here? The flux-sched image only gets updated when changes to flux-sched are merged, so it could be out of date?
There was a problem hiding this comment.
I honestly didn't know there was a flux core one 😆 I always use flux-sched! Even better, I think we should use the containers (TBA) built via GitHub actions and pushed to ghcr.io #4996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: ABI breaks can happen between versions
Solution: run libabigail against release vs. pr
We do this by grabbing the *.so out of the install folder in the latest
fluxrm/flux-sched:focaland comparing against using the same container to build the pull request code. Since Flux is finicky about having a tag for the version, we make a faux one.This will close #4396
Background for the action: https://youtu.be/2Oet0hGOy7U?t=1998
Watch beyond that segment for my Yoda impression!