Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libabigail ABI checks to CI #4396

Open
grondo opened this issue Jul 7, 2022 · 1 comment · May be fixed by #5062
Open

add libabigail ABI checks to CI #4396

grondo opened this issue Jul 7, 2022 · 1 comment · May be fixed by #5062
Assignees

Comments

@grondo
Copy link
Contributor

grondo commented Jul 7, 2022

It might be good to add ABI checks to CI to warn if and when PRs break ABI.

See https://github.com/buildsi/libabigail-action for an example of how this might be done.

Since we publish docker images of the latest merged changes, we might be able to do this without the parallel builds for comparison (just fetch the latest docker image and pull libflux-core.so from there).

@vsoch
Copy link
Member

vsoch commented Apr 3, 2023

hey I made that!! https://youtu.be/2Oet0hGOy7U?t=1998

I can do it.

@vsoch vsoch linked a pull request Apr 3, 2023 that will close this issue
@vsoch vsoch self-assigned this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants