Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade JDK version to 18 for share_plus Android build #2906

Closed
wants to merge 2 commits into from

Conversation

imguptaharsh
Copy link

@imguptaharsh imguptaharsh commented May 4, 2024

Description

This pull request updates the JDK version from 17 to 18 in the share_plus package's Android build configuration. This change affects both the compileOptions and kotlinOptions in the build.gradle file, where the source and target compatibility settings are updated to JavaVersion.VERSION_18 and jvmTarget to '18'. This update was motivated by the need to utilize the latest language features offered by JDK 18, improve performance, and ensure greater security compliance.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits: chore: update JDK version to 18 in share_plus.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files, as this is a build environment change, not a functional change.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

  • Yes, this is a breaking change (please indicate that with a ! in the title).
  • No, this is not a breaking change.

This update to JDK 18 is a backend change that does not affect the exposed functionality or interfaces of the share_plus plugin; therefore, it does not require users to alter their existing applications. This update is intended to streamline development by adopting newer development tools and enhancements in JDK 18.

@imguptaharsh imguptaharsh changed the title Update JDK version in build.gradle Updated JDK version to 18 in build.gradle May 5, 2024
@imguptaharsh imguptaharsh changed the title Updated JDK version to 18 in build.gradle upgrade JDK version to 18 for share_plus Android build May 5, 2024
@imguptaharsh imguptaharsh changed the title upgrade JDK version to 18 for share_plus Android build build: upgrade JDK version to 18 for share_plus Android build May 5, 2024
@vbuberen
Copy link
Collaborator

vbuberen commented May 5, 2024

You need to learn about Java versions more, because what you did in this PR is switch from Java 17 to Java 8 in the project.

Closing as invalid.

@vbuberen vbuberen closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Web]: Cannot build web when package_info_plus is in pubspec.yaml
2 participants