Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove homebrew instructions #6263

Merged
merged 1 commit into from Sep 11, 2021
Merged

Conversation

christopherfujino
Copy link
Member

This removes the instructions added in https://github.com/flutter/website/pull/6124/files. The validity of this cask is uncertain, so we should not be officially recommending it unless its security has been vetted.

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 11, 2021
@christopherfujino
Copy link
Member Author

cc @jmagman

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hixie Hixie merged commit 09a97cb into flutter:main Sep 11, 2021
@christopherfujino christopherfujino deleted the remove-homebrew branch September 11, 2021 17:35
@nathanfallet
Copy link
Contributor

I know a lot of developers working on macOS (including me) prefer to install things using Homebrew (like it can be done with package managers on many linux distributions) to make it simpler and quicker, and allow to update automatically. That's why I opened #6124

@christopherfujino
Copy link
Member Author

I know a lot of developers working on macOS (including me) prefer to install things using Homebrew (like it can be done with package managers on many linux distributions) to make it simpler and quicker, and allow to update automatically. That's why I opened #6124

This was removed from the website not because homebrew isn't useful, but because we hadn't vetted that flutter homebrew package for validity and security.

@Hixie
Copy link
Contributor

Hixie commented Nov 3, 2021

If you would like to help us support homebrew officially, please volunteer on Discord to help us fix flutter/flutter#14050. A solution here would need to be secure and verified so that we know we're not shipping the actual Flutter binaries to people, rather than, as with an unofficial package, having the risk that the package is being manipulated by whoever is setting it up. (Not that I have any reason to believe that that is happening, but I certainly would want to be sure before telling people to use it.) Setting this up will probably require learning how our CI works and working with our infra team to figure out how to do this securely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants