Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Avoid manual configuration of repos when consuming image_picker #191

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

mravn-google
Copy link
Contributor

@mravn-google mravn-google commented Jul 31, 2017

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

@LarkAscending I think this will allow us to simplify the codelab as we can remove the step where we require people to manually add the jitpack repository.

@mravn-google mravn-google merged commit cf255f5 into flutter:master Aug 1, 2017
@mravn-google mravn-google deleted the custom_repo branch August 1, 2017 17:48
@mravn-google
Copy link
Contributor Author

@goderbauer Package should be ready to for publication, but I am not authorized to do that.

@eseidelGoogle
Copy link

If the updated pub site supports group-based acls, we should definitely add a flutter-publishers acl to prevent this kind of thing in the future. :D . @kevmoo

@goderbauer
Copy link
Member

Package should be ready to for publication, but I am not authorized to do that.

@mravn-google Added you as an uploader. You should be able to publish now.

If the updated pub site supports group-based acls

Groups would be sooo awesome!

@mravn-google
Copy link
Contributor Author

Published.

@LarkAscending
Copy link
Contributor

@goderbauer Thanks for the heads up! The codelab uses alpha channel...This is in master, so the next time alpha is updated we'll remove this step.

@LarkAscending
Copy link
Contributor

@LarkAscending
Copy link
Contributor

And image_picker version revved from 0.1.0 to 0.1.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
5 participants