[file_selector_ios, image_picker_ios] Remove Swift Package Support

[vashworth]

Plugins converted to Swift Package Manager that use a modulemap seem to be having issues with there being a module.modulemap. As a temporary solution to unblock people, we'll remove the module.modulemap and Swift Package support (Package.swift).

Temporary solution for flutter/flutter#148307.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[loic-sharma]

LGTM

[stuartmorgan]

Do we have any idea yet why we don't see this in CI? We can land this as is, but it would be nice to have a test that we can ensure we'd don't regress later when re-landing support.

[stuartmorgan]

How about "Temporarily remove Swift Package Manager compatibility to resolve issues with Cocoapods builds."?

[vashworth]

Do we have any idea yet why we don't see this in CI? We can land this as is, but it would be nice to have a test that we can ensure we'd don't regress later when re-landing support.

So far, seems to be older versions of Xcode are having this issue and we don't enforce Xcode 15 yet. So unfortunately impossible to test in CI since macOS 13 does not support Xcode 14 or lower. I misspoke, technically I think macOS 13 does support Xcode 14 (it's macOS 14 that doesn't). We could have duplicate tests and have them run on Xcode 14, but that's probably not worth the capacity it would take.

I'll add an issue to reland this and when they do, to temporarily test with Xcode 14

[stuartmorgan]

Have we actually validated that it's an Xcode 14 vs 15 thing? I thought that was still speculative based on the issue discussion (i.e., nobody seems to have indicated confirming that the same project works in 15 but not 14).

[vashworth]

Have we actually validated that it's an Xcode 14 vs 15 thing? I thought that was still speculative based on the issue discussion (i.e., nobody seems to have indicated confirming that the same project works in 15 but not 14).

I confirmed Xcode 14 breaks: https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_x64%20ios_build_all_packages%20master/484/overview

[jmagman]

I think we can get rid of the manual modulemaps, that was a lot of work to explicit module Test working. We could just do the cheap thing and redeclare the methods we need in the tests.

[vashworth]

I think we can get rid of the manual modulemaps, that was a lot of work to explicit module Test working. We could just do the cheap thing and redeclare the methods we need in the tests.

Unfortunately, we're not the only ones that do this, though. I've seen other plugin authors copy our model to achieve the same. I would think we would want to provide a way for them to maintain it, but yeah the modulemaps are super annoying and I wish we could get rid of them. I'll think on it more.

Example: https://github.com/Baseflow/flutter-geolocator/blob/ca5469fe4212fe82d586bed93634d5e5a0e6154a/geolocator_apple/ios/Classes/GeolocatorPlugin.modulemap#L24

[stuartmorgan]

Have we considered cherry picking an Xcode 15 requirement to 3.22?

[vashworth]

Have we considered cherry picking an Xcode 15 requirement to 3.22?

We could, but this issue isn't the only problem we're having with the double modulemaps. @loic-sharma also ran into an issue when trying to convert camera_avfoundation: https://gist.github.com/loic-sharma/27bd8e3ea0d9ab16cd4b8de03918ec4d

So I think we need to figure out a better way to handle modulemaps