[pigeon] Moves all codec logic to singular custom codec #6600
+4,558
−4,837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
force-pushed
the
customcodecs
branch
from
d43b42e
to
a175295
Compare
11 tasks
stuartmorgan
reviewed
May 9, 2024
packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.cpp
Outdated
Show resolved
Hide resolved
tarrinneal
changed the title
Add test to prevent duplicate entries in Kotlin generator
stuartmorgan
requested changes
May 23, 2024
...igeon/platform_tests/alternate_language_test_plugin/example/ios/RunnerTests/NullFieldsTest.m
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/alternate_language_test_plugin/ios/Classes/CoreTests.gen.h
Outdated
Show resolved
Hide resolved
...atform_tests/test_plugin/android/src/test/kotlin/com/example/test_plugin/AllDatatypesTest.kt
Show resolved
Hide resolved
vashworth
reviewed
May 23, 2024
packages/pigeon/lib/pigeon_lib.dart
Outdated
| @@ -2249,14 +2268,16 @@ ${_argParser.usage}'''; | |||
| options = options.merge(PigeonOptions( | |||
| objcOptions: (options.objcOptions ?? const ObjcOptions()).merge( | |||
| ObjcOptions( | |||
| headerIncludePath: path.basename(options.objcHeaderOut!))))); | |||
| headerIncludePath: options.objcOptions?.headerIncludePath ?? | |||
| path.basename(options.objcHeaderOut!))))); | |||
There was a problem hiding this comment.
Is there a unit test that confirms this resolves flutter/flutter#147587?
When I played with it when I discovered the issue, I also had to change a few other things: flutter/flutter#147587 (comment)
There was a problem hiding this comment.
Still need to finish that part of the pr actually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pigeon] Moves all codec logic to singular custom codec.
Also fixes a few small codec related bugs that have cropped up over time.
fixes flutter/flutter#147454
fixes flutter/flutter#147127
fixes flutter/flutter#147587
fixes flutter/flutter#148065