Re-landing SliverAnimatedList #42485
Conversation
# Conflicts: # packages/flutter/test/widgets/animated_list_test.dart
fluttergithubbot
added
the
framework
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Piinks
added
a: animation
|
@simolus3 Apologies for the additional ping. Merging from the other branch went badly. 😅 |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
cc/ @goderbauer 🙂 |
| /// * [SliverList], which does not animate items when they are inserted or | ||
| /// removed. | ||
| /// | ||
| ///{@tool sample} |
There was a problem hiding this comment.
Since this is an animated list, it would be really cool if it had an animation showing what this sample does. (not required for this PR).
There was a problem hiding this comment.
Cheers! I will add an animated visual via assets-for-api-docs once this lands.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
@goderbauer This is ready for another look. Sorry for the bot noise. 🤖 |
Co-Authored-By: Michael Goderbauer <goderbauer@google.com>
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Description
Original PR (#28834) was reverted due to merge conflicts.
Will follow-up with an animation of the included sample app.
Related Issues
Fixes #11339
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?