Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ThemeData.accentColor connection to secondary color #31295

Merged
merged 4 commits into from Apr 27, 2019
Merged

Improve ThemeData.accentColor connection to secondary color #31295

merged 4 commits into from Apr 27, 2019

Conversation

shihaohong
Copy link
Contributor

Description

Added some documentation to highlight that ThemeData.accentColor is synonymous with secondary color.

Related Issues

Fixes #3856

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@shihaohong shihaohong added d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2019
HansMuller
HansMuller previously requested changes Apr 26, 2019
View reviewed changes
packages/flutter/lib/src/material/theme_data.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/theme_data.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/painting/text_style.dart Outdated Show resolved Hide resolved
@shihaohong shihaohong dismissed HansMuller’s stale review April 26, 2019 17:37

Re-requested review

HansMuller
HansMuller approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit 7c4ccb3 into flutter:master Apr 27, 2019
@shihaohong shihaohong mentioned this pull request Apr 27, 2019
Closed
@shihaohong shihaohong deleted the text-style-secondary-color branch May 14, 2019 17:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Best way to color text the secondary color of current theme?
3 participants
@shihaohong @HansMuller @googlebot