Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Java EE module to SDK manager calls #16035

Merged
merged 1 commit into from Apr 3, 2018
Merged

Adds Java EE module to SDK manager calls #16035

merged 1 commit into from Apr 3, 2018

Conversation

lukef
Copy link
Contributor

@lukef lukef commented Mar 28, 2018 •
edited

This PR adds an environment variable to the Android SDK Manager calls that re-enables the deprecated java EE module to allow SDK manager to run. This is a workaround and the fix should be done in the Android tools. However, without that fix, Flutter will be broken.

Fixes: #16025

See:
https://bugs.openjdk.java.net/browse/JDK-8189188
https://stackoverflow.com/questions/47150410/failed-to-run-sdkmanager-list-android-sdk-with-java-9

tvolkert
tvolkert approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvolkert tvolkert merged commit 0c18d29 into flutter:master Apr 3, 2018
@cbracken
Copy link
Member

cbracken commented Apr 3, 2018 •
edited

On my machine, this triggers the following error, which causes #16025 to return LicensesAccepted.unknown:

% SDKMANAGER_OPTS="--add-modules java.se.ee" /Users/cbracken/Library/Android/sdk/tools/bin/sdkmanager --licenses
Unrecognized option: --add-modules
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit

A run of sdkmanager --version returns 26.1.1 for me.

@tvolkert
Copy link
Contributor

tvolkert commented Apr 4, 2018

I get the same error with this change. I'm going to revert. @lukef can you repro the problem, then re-submit the patch with a version that works in all environments?

@tvolkert tvolkert mentioned this pull request Apr 4, 2018
Merged
@tvolkert
Copy link
Contributor

tvolkert commented Apr 4, 2018

Revert PR: #16227

tvolkert added a commit that referenced this pull request Apr 4, 2018
@tvolkert
Revert "Adds Java EE module to SDK manager calls" (#16227)
d4084cd 
This reverts #16035
This was referenced Apr 4, 2018
Closed
Closed
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@lukef @tvolkert
Adds Java EE module to SDK manager environment to stop missing xml li…
d9d7163 
…brary exception when checking for licenses. (flutter#16035)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@tvolkert
Revert "Adds Java EE module to SDK manager calls" (flutter#16227)
c3af207 
This reverts flutter#16035
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tvolkert tvolkert tvolkert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✗ Android license status unknown.
4 participants
@lukef @cbracken @tvolkert @googlebot