-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate androidx.window to 1.1.0 stable #52474
Conversation
Note that since androidx.window is a maven dependency (and not a CIPD dependency), step 7 and 8 of the android_embedding_bundle/README.md were skipped. Bug: 314377438 Test: et build -c android_debug_arm64
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@kchyn3 it looks like the android tests are all failing. |
@kchyn3 Any updates on the failing tests? |
FYI this will be covered in #53001 |
I think the tests are failing because I don't have access to update CIPD deps in steps 7-9 here, last time when I checked the logs looks like it couldn't find the new dependencies. https://github.com/flutter/engine/blob/main/tools/cipd/android_embedding_bundle/README.md#steps Thanks for the heads up, I'll abandon this change. |
@kchyn3 I thought we found out that you did not need to update cipd to modify androidx.window since it was downloaded from maven. |
That's what we initially thought. But I chatted with Jonah a bit on discord and it looks like the presubmit runs couldn't find the new artifacts so we are assuming that the command does in fact need to be run 🤷 |
I would guess that the confusion here is that the dependencies in |
Updates the androidx.window dependency from 1.1.0-beta04 to 1.1.0-stable.
Note that since androidx.window is a maven dependency (and not a CIPD dependency), step 7 and 8 of the android_embedding_bundle/README.md were skipped.
Issue: 129307
Test: et build -c android_debug_arm64
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.