Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all V2 classes #3725

Merged
merged 3 commits into from
May 20, 2024
Merged

Rename all V2 classes #3725

merged 3 commits into from
May 20, 2024

Conversation

stuartmorgan
Copy link
Contributor

Now that all v1 Buildbucket code is gone, remove the V2 from all the names of the replacements.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
Copy link
Contributor Author

@christopherfujino Ping on this? It should be straightforward to review, and it touches a lot of code so I'd like to get it landed to avoid issues with other PRs.

christopherfujino
christopherfujino approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I forgot about reviewing this last week.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App. label May 20, 2024
@auto-submit auto-submit bot merged commit f41c5b7 into flutter:main May 20, 2024
3 checks passed
@stuartmorgan stuartmorgan deleted the buildbucket-v2-renaming branch May 20, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @christopherfujino