-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link branches to main
#3671
base: main
Are you sure you want to change the base?
Conversation
@@ -1053,9 +1053,9 @@ class BuilderConfig extends $pb.GeneratedMessage { | |||
/// Lower means more important. | |||
/// | |||
/// The default value is configured in | |||
/// https://chrome-internal.googlesource.com/infradata/config/+/master/configs/cr-buildbucket/swarming_task_template.json | |||
/// https://chrome-internal.googlesource.com/infradata/config/+/89dede6f6a67eb06946a6009a6a88d377e957d25/configs/cr-buildbucket/swarming_task_template.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted and this is the last commit
@@ -80,7 +80,7 @@ targets: | |||
|
|||
# | |||
# Devicelab example: | |||
# For tests that are located https://github.com/flutter/flutter/tree/master/dev/devicelab/bin/tasks: | |||
# For tests that are located https://github.com/flutter/flutter/tree/main/dev/devicelab/bin/tasks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default branch for flutter/flutter is master, not main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm anticipating the imminent (?) switch to main
and future deprecation of master
, according to flutter/flutter#121564. main
copies commits from master
so all links are valid
@@ -419,7 +419,7 @@ release_build: "true" | |||
</tr> | |||
<tr> | |||
<td>shard</td> | |||
<td>The shard name of the sharding target, used in the <a href="https://github.com/flutter/flutter/blob/master/dev/bots/test.dart">test.dart</a> test runner. | |||
<td>The shard name of the sharding target, used in the <a href="https://github.com/flutter/flutter/blob/main/dev/bots/test.dart">test.dart</a> test runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter/flutter should stay master.
@@ -432,7 +432,7 @@ shard: web_tests | |||
</tr> | |||
<tr> | |||
<td>subshards</td> | |||
<td>The sub shards of the sharding target, used in the <a href="https://github.com/flutter/flutter/blob/master/dev/bots/test.dart">test.dart</a> test runner. | |||
<td>The sub shards of the sharding target, used in the <a href="https://github.com/flutter/flutter/blob/main/dev/bots/test.dart">test.dart</a> test runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter/flutter should stay master.
@@ -54,7 +54,7 @@ made of multiple _tasks_. Tasks are _performed_ by _LUCI bots_. | |||
## Getting started | |||
|
|||
First, [set up a Flutter development | |||
environment](https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md#developing-for-flutter). | |||
environment](https://github.com/flutter/flutter/blob/main/CONTRIBUTING.md#developing-for-flutter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etc
Tested links manually and fixes a few broken or deprecated links
Added a test that validates that
master
isn't used, except for specified repos.Part of flutter/flutter#121564
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.