Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1737: Don't apply AUTOINCREMENT on non-identity PK #1744

Merged
merged 1 commit into from Mar 19, 2024

Conversation

schambers
Copy link
Member

Fixes regression introduced where non-identity, primary key columns always attempt to create with "AUTOINCREMENT" which is only valid for integer identity columns. Fixes issue #1737

@schambers
Copy link
Member Author

If there's no objections here @jzabroski, I'll merge this, this week and close it out

@jzabroski jzabroski changed the title #1737: Don't attempt to apply AUTOINCREMENT #1737: Don't apply AUTOINCREMENT on non-identity PK Mar 19, 2024
@jzabroski jzabroski added the db:sqlite SQLite specific label Mar 19, 2024
@jzabroski jzabroski merged commit b2369ca into main Mar 19, 2024
3 checks passed
Copy link
Collaborator

@jzabroski jzabroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schambers schambers deleted the feature/issue-1737-sqlite-pk branch March 21, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db:sqlite SQLite specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants