Don't attempt to apply AUTOINCREMENT for non-identity, primary key co…

…lumns in Sqlite. Fixes issue #1737
fluentmigrator · Mar 15, 2024 · 7da19ee · 7da19ee
1 parent 6720e1b
commit 7da19ee
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/FluentMigrator.Runner.SQLite/Generators/SQLite/SQLiteColumn.cs b/src/FluentMigrator.Runner.SQLite/Generators/SQLite/SQLiteColumn.cs
@@ -71,7 +71,9 @@ protected override string FormatIdentity(ColumnDefinition column)
                     throw new ArgumentException($"Cannot create identity constraint on column {column.Name}. SQLite only supports identity on a single integer, primary key column.");
                 }
 
-                return "AUTOINCREMENT";
+                if (column.IsPrimaryKey) {
+                    return "AUTOINCREMENT";
+                }
             }
 
             return string.Empty;

diff --git a/test/FluentMigrator.Tests/Integration/Processors/SQLite/SQLiteProcessorTests.cs b/test/FluentMigrator.Tests/Integration/Processors/SQLite/SQLiteProcessorTests.cs
@@ -128,6 +128,20 @@ public void IsEscapingTableNameCorrectlyOnColumnExists()
             Processor.ColumnExists(null, _tableNameThatMustBeEscaped, columnName).ShouldBeTrue();
         }
 
+        [Test]
+        public void PrimaryKeyNonIdentityColumnsSupported()
+        {
+            var expression = new CreateTableExpression { TableName = _tableName };
+            expression.Columns.Add(new ColumnDefinition {Name = "Id", Type = DbType.Int32, IsPrimaryKey = false, IsIdentity = true, IsNullable = false });
+            expression.Columns.Add(new ColumnDefinition {Name = "Key1", Type = DbType.String, IsPrimaryKey = true, IsIdentity = false, IsNullable = false });
+            expression.Columns.Add(new ColumnDefinition {Name = "Key2", Type = DbType.String, IsPrimaryKey = true, IsIdentity = false, IsNullable = false });
+
+            Processor.Process(expression);
+            Processor.ColumnExists(null, _tableName, "Id").ShouldBeTrue();
+            Processor.ColumnExists(null, _tableName, "Key1").ShouldBeTrue();
+            Processor.ColumnExists(null, _tableName, "Key2").ShouldBeTrue();
+        }
+
         [Test]
         public void AGuidCanBeInsertedAndReadAgain([Values] bool binaryGuid)
         {