Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli)!: hopon virtual instruction in the beautifier #840

Merged
merged 11 commits into from
May 24, 2024

Conversation

monoid
Copy link
Contributor

@monoid monoid commented May 13, 2024

It recognizes certain constructions generated by the Compiler, and outputs it in a readable form.

It recognizes certain constructions generated by the Compiler, and
outputs it in readable form.
@monoid monoid added P-low priority: low C-feature category: a new feature request labels May 13, 2024
@monoid monoid self-assigned this May 13, 2024
Copy link

linear bot commented May 13, 2024

@fluencebot fluencebot added the e2e Run e2e workflow label May 14, 2024
tools/cli/air/src/beautify/mod.rs Outdated Show resolved Hide resolved
#[wasm_bindgen]
pub fn beautify_raw(air_script: String) -> Result<String, JsError> {
let mut output = vec![];
air_beautifier::beautify(&air_script, &mut output, false)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it false here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false means "do not recognize patterns", i.e. emitting AIR as it was before ("raw").

crates/beautifier/src/tests/mod.rs Outdated Show resolved Hide resolved
crates/beautifier/src/tests/mod.rs Outdated Show resolved Hide resolved
crates/beautifier/src/beautifier.rs Outdated Show resolved Hide resolved
monoid and others added 7 commits May 14, 2024 20:29
Co-authored-by: InversionSpaces <InversionSpaces@vivaldi.net>
pos in stream and canon name always reflect their occurence in text,
without resolving to declaration position.
@monoid monoid changed the title feat(cli): pattern recognition in the beautifier feat(cli): hopon pattern recognition in the beautifier May 23, 2024
@monoid monoid changed the title feat(cli): hopon pattern recognition in the beautifier feat(cli): hopon virtual instruction in the beautifier May 23, 2024
@monoid monoid changed the title feat(cli): hopon virtual instruction in the beautifier feat(cli)!: hopon virtual instruction in the beautifier May 24, 2024
@monoid monoid merged commit 04bacb7 into master May 24, 2024
21 of 24 checks passed
@monoid monoid deleted the feat/VM-315-add-hop-pattern-to-beautifier branch May 24, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature category: a new feature request e2e Run e2e workflow P-low priority: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants