chore(show): Rename search-term to pkg-path #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To indicate to the user that we're matching a single item rather than searching for multiple packages with a partial string. I've left the naming in `construct_show_params` and below because it's specific to `pkgdb` terminology.
dcarley
force-pushed
the
dcarley/show-rename-arg
branch
from
625e892
to
b537848
Compare
mkenigs
requested changes
May 10, 2024
|
The man page is generated from |
|
@dcarley can you also update the example then? |
mkenigs
approved these changes
May 10, 2024
ysndr
approved these changes
May 14, 2024
mkenigs
approved these changes
May 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
## Proposed Changes To indicate to the user that we're matching a single item rather than searching for multiple packages with a partial string. I've left the naming in `construct_show_params` and below because it's specific to `pkgdb` terminology. --- Noticed this while working on #1444 which it may cause merge conflicts with but thought it was worth reviewing in its own right. ## Release Notes N/A, probably not worth mentioning. --------- Co-authored-by: Yannik Sander <7040031+ysndr@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To indicate to the user that we're matching a single item rather than searching for multiple packages with a partial string.
I've left the naming in
construct_show_paramsand below because it's specific topkgdbterminology.Noticed this while working on #1444 which it may cause merge conflicts with but thought it was worth reviewing in its own right.
Release Notes
N/A, probably not worth mentioning.