add support for fish and tcsh shells #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limeytexan
force-pushed
the
fish-and-tcsh
branch
2 times, most recently
from
d05824d
to
fa5fd87
Compare
limeytexan
force-pushed
the
issue-1187
branch
2 times, most recently
from
3c3e633
to
f9caf58
Compare
limeytexan
force-pushed
the
fish-and-tcsh
branch
3 times, most recently
from
1071e76
to
65e11a2
Compare
limeytexan
force-pushed
the
issue-1187
branch
4 times, most recently
from
779a4b9
to
67a0e41
Compare
limeytexan
force-pushed
the
fish-and-tcsh
branch
3 times, most recently
from
3118022
to
d4d4a0b
Compare
limeytexan
commented
May 23, 2024
limeytexan
commented
May 23, 2024
limeytexan
commented
May 23, 2024
limeytexan
force-pushed
the
fish-and-tcsh
branch
2 times, most recently
from
7c03ba1
to
44b7b6d
Compare
The perils of creating our own quoting function is that we're destined
to repeat lessons of the past, but of course the advantage is that we have
more precise control of the outcome. This patch adds logic to similarly
escape the backtick (`) character. (I rather suspect our next step will
be to escape the single quote ('), followed by conditional logic to avoid
escaping when within them.)
Following PR#1299 it was fairly straightforward to add support for the fish and tcsh shells. This patch adds this support along with tests that mirror those that already exist for bash and zsh. Also removed `posixIfThen` and `posixSetEnv` C++ macros no longer required since merging PR#1299.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds support for the
fishandtcshshells based on the refactoring offlox activateperformed in #1299.Also removed
posixIfThenandposixSetEnvC++ macros no longer required since merging PR#1299.Release Notes
fishandtcshshells.