Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQN for flow #964

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

DQN for flow #964

wants to merge 45 commits into from

Conversation

pengyuan-zhou
Copy link
Contributor

@pengyuan-zhou pengyuan-zhou commented Jun 11, 2020

Hi,

This is a branch to enable DQN (also by ray) for flow.
Currently it supports single agent and multi-agent tests on traffic_light_grid scripts.

Other examples can be easily enabled by modifying corresponding example file, env file and test file, according to the modifications in this branch.

Cheers,
Pengyuan

@pengyuan-zhou
Copy link
Contributor Author

Ya I have zero ideas why the build fails, it works on my pc (without the unittest).

@eugenevinitsky
Copy link
Member

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

@pengyuan-zhou
Copy link
Contributor Author

Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example.

Sure, I'll revise it. BTW in that train.py, is the TD3 in setup_exps_rllib same with the one in h-baseline?

.travis.yml Outdated Show resolved Hide resolved
examples/train.py Outdated Show resolved Hide resolved
@eugenevinitsky
Copy link
Member

This looks good to me minus comments! @pengyuan-zhou if the changes are made I will merge.

.travis.yml Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
@pengyuan-zhou
Copy link
Contributor Author

@eugenevinitsky
Copy link
Member

Hey! I'm really sorry about the state of things here, we are working on getting a new maintainer in the next week or so so this doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants