Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartbar enhancements #2477

Merged
merged 3 commits into from
May 29, 2024

Conversation

lm41
Copy link
Collaborator

@lm41 lm41 commented May 14, 2024

Closes #2415
Closes #2049

@lm41 lm41 requested a review from patrickgold May 14, 2024 14:15
@lm41 lm41 self-assigned this May 14, 2024
@itsmartashub
Copy link

itsmartashub commented May 14, 2024

While you're working on this issue, I was wondering if the last copied item should still be 'pasteable' even after we remove all items from the Florisboard clipboard?

If this isn't default behavior but rather a bug, perhaps it's also related to the fact that even when we delete all items from the clipboard, the paste button still maintains that 'active paste' state because the last copied item hasn't been removed from some paste "storage" (idk how to named the place where it still hangs)

I'm sorry if this isn't the right place to ask.

EDIT:

Ah, sorry, I was wrong. I just realised that Clear Clipboard History does not clear the last copied item, and that there is a separate Clear Primary Clip button for that. And with that logic, the active paste state works like a charm now

@lm41 lm41 removed the request for review from patrickgold May 14, 2024 18:01
@lm41 lm41 marked this pull request as draft May 14, 2024 18:01
@lm41 lm41 marked this pull request as ready for review May 14, 2024 18:17
@lm41 lm41 changed the title Fix incorrect smartbar paste button state Smartbar enhancements May 25, 2024
@lm41 lm41 requested a review from patrickgold May 25, 2024 18:25
Copy link
Member

@patrickgold patrickgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes!

I have reviewed the code and tested out the code, it works really well. My requested changes are only nitpicks or code cleanup, once that's done this is good to merge in.

@patrickgold patrickgold merged commit 4c0c3f5 into florisboard:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants