Add addons support #2473
Draft
Add addons support #2473
+211
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickgold
added
the
area: settings
Possible to do via addon? |
No, due to the fact that this feature requires reading the xml colors of the target app and those are a mess nowadays due to Material 1 2 and 3 all being out in the wild, and together with apps using Jetpack Compose those colors often times do not match at all what the apps colors are, thus I removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2468
Please only give implementation feedback in this comment thread, for general feedback regarding the addons integration as planned comment in the related issue!
Due to the theme screen rework in conjunction with addons it has been decided that the adapt to app theming option will be entirely removed (which wasn't working anyways for like the last 2 stable versions). There are no plans for re-adding this feature again anytime soon. The following issues are closed as not-planned: #274 #399 #853 #1216 #1313 #1338