Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Latin NLP provider (part 2) #2209

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

patrickgold
Copy link
Member

@patrickgold patrickgold commented May 8, 2023

This PR is a continuation of #2196.

Status: NLP bridge is partially implemented; resolving bugs and performance issues; trying to find solution for currently broken glide typing

Relevant PRs:


Closes #2150
Closes #2155

@patrickgold patrickgold changed the title Add experimental dictionary manager screen Implement Latin NLP provider (part 2) May 8, 2023
@BHydden
Copy link
Collaborator

BHydden commented May 11, 2023

Feels close 🙂 odd after all this time! 😁

@patrickgold
Copy link
Member Author

It's getting closer and closer each commit - but as you might see from the changes I have to account for quite a lot of stuff in the JNI bridge itself before the actual suggestions are displayed. ATM I got C++ exceptions to properly be handled (as ICU extensions and also the NLP core depend on exceptions for unexpected behavior). And I played around with some of the NlpSession bridging, which seems to work for now.

So if nothing goes wrong in the next few days there will be the first app-debug.apk artifact with suggestions working :)

@lm41
Copy link
Collaborator

lm41 commented May 11, 2023

How long I have waited for this.... Finally, the messages I write will no longer look like those of a drunk. Thanks for everything

@Rorschach1010
Copy link

I installed this apk so I finally can use Florisboard with glide and a german dictionary but somehow when I activate glide typing, it's not working at all. Am I doing something wrong? When I install the latest beta, glide typing is working.

Plugins can now specify a settings activity and a short/long description
Additionally add PluginViewScreen
The IPC communication causes significant lag atm.
This new API allows the UI to dynamically check if a subtype is supported by a given NLP Provider.
This should improve compile performance for workflow runners.
@patrickgold patrickgold marked this pull request as draft December 10, 2023 22:17
@antaljanosbenjamin
Copy link
Contributor

If you need help with the C++ part, I can try to help. I am not too familiar with C++ on android, but I am using C++ on my daily job. Feel free to ping me, if you need help.

@MartinNowak
Copy link

Do you have some sort of todo list for this PR with which we could help you @patrickgold?
Or maybe we could break the topic down a bit and help with a few PRs to finish this feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipping text just in english Glide Typing will suggest sexual words
6 participants