-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Latin NLP provider (part 2) #2209
base: master
Are you sure you want to change the base?
Conversation
Feels close 🙂 odd after all this time! 😁 |
It's getting closer and closer each commit - but as you might see from the changes I have to account for quite a lot of stuff in the JNI bridge itself before the actual suggestions are displayed. ATM I got C++ exceptions to properly be handled (as ICU extensions and also the NLP core depend on exceptions for unexpected behavior). And I played around with some of the NlpSession bridging, which seems to work for now. So if nothing goes wrong in the next few days there will be the first app-debug.apk artifact with suggestions working :) |
How long I have waited for this.... Finally, the messages I write will no longer look like those of a drunk. Thanks for everything |
I installed this apk so I finally can use Florisboard with glide and a german dictionary but somehow when I activate glide typing, it's not working at all. Am I doing something wrong? When I install the latest beta, glide typing is working. |
These utils provide a safe way for native C++ code to throw exception and to be properly forwarded to the JVM via the JNI interface. Most of the C++ STL exceptions have their specific exception class counterpart in Kotlin, for all other C++ exceptions the std::exception base catch statement is used.
This module contains all data objects that are both relevant for the plugin module and the core app module
Plugins can now specify a settings activity and a short/long description
Additionally add PluginViewScreen
The IPC communication causes significant lag atm.
… native compilation
This new API allows the UI to dynamically check if a subtype is supported by a given NLP Provider.
This should improve compile performance for workflow runners.
5420197
to
9990268
Compare
If you need help with the C++ part, I can try to help. I am not too familiar with C++ on android, but I am using C++ on my daily job. Feel free to ping me, if you need help. |
Do you have some sort of todo list for this PR with which we could help you @patrickgold? |
This PR is a continuation of #2196.
Status: NLP bridge is partially implemented; resolving bugs and performance issues; trying to find solution for currently broken glide typing
Relevant PRs:
LatinNlpSession
nlp#5Closes #2150
Closes #2155