Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJK keyboard adjustments for better Chinese input convenience #2142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moonbeamcelery
Copy link
Contributor

  • fix full-width comma
  • add () to first symbol screen popups
  • merge postal sign with # popups
  • add = to + popup
  • add full-width = to half-width popup
  • fix half-width <> and single guillemets ‹›
  • add check mark to square root symbol popup
  • Add [] to popups
  • Add pinyin characters in popup mapping

TODO:

  • Consider making the full- and half-width toggle instead have three states. Add a state that is full-width for punctuation but half-width for other characters.
  • Actually test

@moonbeamcelery
Copy link
Contributor Author

Pulling in @Waelwindows for comments, because I am not sure how much this impacts Japanese input convenience.

@Waelwindows
Copy link
Collaborator

Looks good to me!

@moonbeamcelery moonbeamcelery marked this pull request as ready for review January 19, 2023 05:09
@moonbeamcelery
Copy link
Contributor Author

Thanks! In that case, this is ready for merging, unless you want me to finish the three-state full/half width toggle idea in this PR.

@Waelwindows
Copy link
Collaborator

You could open a different PR for that

- fix full-width comma
- add () to first symbol screen popups
- merge postal sign with # popups
- add = to + popup
- add full-width = to half-width popup
- fix half-width <> and single guillemets ‹›
- add check mark to square root symbol popup
- Add [] to popups
- Add pinyin characters in popup mapping

Signed-off-by: moonbeamcelery <moonbeamcelery@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants