-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance APIKey ModelAdmin Class #203
base: master
Are you sure you want to change the base?
Enhance APIKey ModelAdmin Class #203
Conversation
- Adding ("expiry_date", "revoked") to list_filter - Adding search_help_text (New in Django 4.0) - Adding "revoked" to readonly_fields (Depend on the New revoke action to revoke an APIKey) - Adding Organized fieldsets - Adding ("revoke", "verify") actions - Adding test-cases cover the changes
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 97.11% 97.70% +0.58%
==========================================
Files 22 22
Lines 520 653 +133
==========================================
+ Hits 505 638 +133
Misses 15 15
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Thanks again @Mustafa-Abu-Ghazy for opening this. As in #204, I need to ask for us to write up what problem these changes help address. If possible, let's do this in an issue explaining what practical problems or limitations currently exist with the default ModelAdmin. |
… same authorization level as before.
Hi @florimondmanca, It's not a problem as much it's enhancement for the user experience while dealing with the APIKeyModelAdmin
Both of |
Enhance APIKey ModelAdmin Class
Adding ("expiry_date", "revoked") to list_filter
Adding search_help_text (New in Django 4.0)
Adding "revoked" to readonly_fields (Depend on the New revoke action to revoke an APIKey)
Adding Organized fieldsets
Adding ("revoke", "verify") actions
Adding test-cases cover the changes