Mouse wheel message is setting invalid mouse position. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates. Do not call _sapp_win32_mouse_update.
|
Hmm this was bulk change in this commit, I wasn't aware that the WM_MOUSEWHEEL messages have a different behaviour: I actually need to check whether the other affected messages are also wrong. |
|
The other messages do not seem to have this problem. |
|
Ok merged! Thanks for spotting this issue and providing a PR. I'll try to look at least into #830 over the next few days (as I said there, need to check the other platforms, if Linux and macOS needs the same fix I'll do it as part of the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MOUSEWHEEL messages provide the mouse position in absolute coordinates, so updating it the same way you respond to other mouse messages is not correct. One solution would be to translate the mouse coordinates to client space, but it's not clear to me why this is being updated here.
This problem was introduced recently and my application was working fine before it. I can implement a different workaround if the mouse_update call is necessary for reasons that I'm not aware of. For example, we could pass a flag to transform the coordinates when necessary.