Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the PR implements the NSTextInputClient ( #460 ) for
MTKView
andNSOpenGLView
, this will allow_sapp_macos_app
to receive key code for characters likeá, é, í, ó, ú
a couple of notes:
_sapp.event.char_code
is set insideinsertText
method._sapp.event.modifiers
and_sapp.event.key_repeat
are still insidekeyDown
I'm not sure if this is going to break something, but it looks correct.firstRectForCharacterRange
is returningreturn NSMakeRect(0.0, 0.0, 0.0, 0.0);
. the original impl uses the window bounds, I'm not sure what is the difference here..This is my first PR here, so feel free to point any corrections, etc.. =)