Adds SOKOL_NOAPI to WIN32 #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those CI errors are unrelated. Looks like the Spine C API has changed. I'll look into it. |
|
Ok, I pinned the spine version used in the tests to 4.1 in the master branch. Can you rebase your PR on top of master? The actual changes are looking good. Surprising that it's so few changes actually :) |
|
Indeed, definitely not a revolutionizing change by any means, but very handy if you need to step out of the supported render backends (like our use case with vulkan/webgpu-native). Shoutout to @castano who actually did the work. And sorry for the belated commit :P |
|
Ok merged, thanks! I'll also add a small changelog blurb. |
floooh
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to support "NO_API" on windows.