Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf & JSONSchema support #50

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Protobuf & JSONSchema support #50

wants to merge 16 commits into from

Conversation

tPl0ch
Copy link
Collaborator

@tPl0ch tPl0ch commented Oct 16, 2020

Fixes #41

@TheLevti
Copy link

Good morning @tPl0ch

Would it be possible to get a status update on this issue? And how we could help or what is needed to push this to a finished state.

@nickpoulos
Copy link

Bump on this.

@tPl0ch @TheLevti I would love get a little discussion group going to see if we can't knock this feature out of the park.

Are either of you interested/available in the near future?

@TheLevti
Copy link

TheLevti commented Aug 12, 2021

Bump on this.

@tPl0ch @TheLevti I would love get a little discussion group going to see if we can't knock this feature out of the park.

Are either of you interested/available in the near future?

We did not wait for this package any longer and instead developed our own package to support the json schema registry. Our current plan is to open source our implementation some time in the future. But sure, I am in for any talk/discussions.

@tPl0ch
Copy link
Collaborator Author

tPl0ch commented Aug 13, 2021

@TheLevti may I ask what the reason was to build another library instead of contributing to this one? This question is not meant to be judgemental, but I am just curious if this is library is not approachable for others.

@TheLevti
Copy link

@TheLevti may I ask what the reason was to build another library instead of contributing to this one? This question is not meant to be judgemental, but I am just curious if this is library is not approachable for others.

We could not wait :). Also we checked our requirements and we just needed json schema registry implementation and thats what we did. As far as I understood, this library wants to add a general schema registry implementation for several formats.

@lubagov
Copy link

lubagov commented Oct 18, 2021

I understand that the problem is in the difficulty of understanding code of this library... I do not understand it yet. But I really need Protobuf. What is now in this branch how much usable? Can I implement own wrapper to serialize Protobuf, and use it for work with schemas?

(Although it is obvious that the schema registry APIs are similar, and call the same REST APIs regardless of the schema type, and handle them the same way).

@nickpoulos
Copy link

@tPl0ch is there a discord or something where we can discuss this PR?

As others have mentioned, this code base is difficult to dive into without some kind of guidance.

It has been a few years and Protobuf support is a feature my team has been desperate to get implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProtoBuf & JSON Schema support
4 participants