Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images component, background image component #642

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nadenislamarre
Copy link

No description provided.

these libs (as single file) are used to load textures from files

Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
for the moment, this file includes only textures loading for opengl.
imgui lacks a working vulkan addImage function.

Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
images textures need rgba (to load alpha for example for decorations).
thus, this commit globally convert gl textures in rgba

Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
image : to display an image component (only one component of type image can be rendered)
        note that the texture is never cleared, nor reloaded (in case of configuration modification).

image_max_width: by default, the width of the image is the one of the pannel (value is 0). with this
                 option, you can reduce it.

image_background: global background image to display

Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
Signed-off-by: Nicolas Adenis-Lamarre <nicolas.adenis.lamarre@gmail.com>
@jackun
Copy link
Collaborator

jackun commented Jun 7, 2022

Do you have a use case with vulkan to see if it works for you? :P
https://github.com/flightlessmango/MangoHud/tree/pr-642

Some stuff needs some more ironing out (reloading etc.) but should be usable already.
(e: even Godot editor works)

@nadenislamarre
Copy link
Author

it has worked on batocera.linux distribution (batocera.org) on the stable version for monthes on x86_64/rpi/odroids opengl/vulkans. i can give you a screenshot if you want.

@jackun
Copy link
Collaborator

jackun commented Jun 7, 2022

I mean if my changes work in pr-642 :D
https://github.com/flightlessmango/MangoHud/tree/pr-642

@nadenislamarre
Copy link
Author

is it ok for this pr with your changes ? Should i do somethinig ?
i tested your changes successfully.

@jackun
Copy link
Collaborator

jackun commented Nov 7, 2022

Nah, I need to figure out how to deal with vulkan concurrency issues (destroying texture while it's still being used)

@nadenislamarre
Copy link
Author

hum. any update ?

@nadenislamarre
Copy link
Author

the branch pr-642 is becoming very far from master and tag 0.6.8 ; this branch is becoming complex to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants