Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/flipper_xcode_15.3 #1474

Merged
3 commits merged into from Apr 3, 2024
Merged

fix/flipper_xcode_15.3 #1474

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e43accc
fix/flipper_xcode_15.3
ElenaDiachenko Mar 18, 2024
9dde487
fix: change e2e selector because renative text has been removed from …
Mar 18, 2024
8bc33a3
make flipper usage configurable
ElenaDiachenko Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app-harness/src/app/index.tsx
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ const AppContent = () => {
<Image
style={styles.logo}
source={ICON_LOGO}
{...testProps('template-starter-home-screen-renative-image')}
{...testProps('app-harness-home-screen-renative-image')}
/>
<Text style={styles.introText} {...testProps('app-harness-home-screen-intro-text')}>
ReNative Harness
Expand Down
4 changes: 2 additions & 2 deletions packages/app-harness/test/specs/e2e.cjs
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ describe('Test App Harness', () => {
FlexnRunner.launchApp();
});

it('--> check if element has correct text in Home Page', async () => {
await FlexnRunner.expectToHaveTextById('app-harness-home-screen-intro-text', 'ReNative Harness');
it('--> check if ReNative logo is displayed in Home Page', async () => {
await FlexnRunner.expectToBeDisplayedById('app-harness-home-screen-renative-image');
});
});
13 changes: 13 additions & 0 deletions packages/engine-rn-tvos/templates/platforms/tvos/Podfile
View file
Open in desktop
Expand Up @@ -82,6 +82,19 @@ post_install do |installer|
:mac_catalyst_enabled => false
)
{{INJECT_POST_INSTALL}}

installer.pods_project.targets.each do |target|
if target.name == 'Flipper'
file_path = 'Pods/Flipper/xplat/Flipper/FlipperTransportTypes.h'
contents = File.read(file_path)
unless contents.include?('#include <functional>')
File.open(file_path, 'w') do |file|
file.puts('#include <functional>')
file.puts(contents)
end
end
end
end
end

{{INJECT_PLUGIN_PODFILE_INJECT}}
13 changes: 13 additions & 0 deletions packages/engine-rn/templates/platforms/ios/Podfile
View file
Open in desktop
Expand Up @@ -65,6 +65,19 @@ target 'RNVApp' do
:mac_catalyst_enabled => false
)
{{INJECT_POST_INSTALL}}

installer.pods_project.targets.each do |target|
if target.name == 'Flipper'
file_path = 'Pods/Flipper/xplat/Flipper/FlipperTransportTypes.h'
contents = File.read(file_path)
unless contents.include?('#include <functional>')
File.open(file_path, 'w') do |file|
file.puts('#include <functional>')
file.puts(contents)
end
end
end
end
end
end

Expand Down