Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI fixes #1452

Merged
merged 11 commits into from Mar 10, 2024
Merged

CLI fixes #1452

merged 11 commits into from Mar 10, 2024

Conversation

pavjacko
Copy link
Member

@pavjacko pavjacko commented Mar 8, 2024

Description

Fixes:

  • rnv configure would not trigger task but autocomplete of configureSoft
  • cannot override template behavior like copy includedPaths assets every run
  • prio tasks missing if running with single engine project
  • improve logger color schema
  • make logger display relative paths all the way to system root
  • handle broken symlinks state
  • avoid attempt to load all engines for global tasks which do not need it (ie rnv link)

How to test includedPaths (this test cannot be performed by scheme or command switch):

TEST 1:

cd app-harness
  1. delete any of the files:
"tsconfig.json",
 "Gemfile",
  "metro.config.js",
   ".bundle",
    "react-native.config.js",
    "babel.config.js",
     "next.config.js",
      "next-env.d.ts",
     "webpack.config.js"
npx rnv configure -p ios

Expected Result:

deleted files should be recreated

TEST 2:

run step 1,2

  1. add following to app-harness/renative.json
"templateConfig": {
        "includedPaths": [
            "next.config.js",
        ]
}
npx rnv configure -p ios

Expected Result:

only next.config.js should be recreated

Related issues

  • GH issues

Npm releases

n/a

@pavjacko pavjacko self-assigned this Mar 8, 2024
@pavjacko pavjacko added this to the 1.0 milestone Mar 8, 2024
@mihaiblaga89 mihaiblaga89 marked this pull request as draft March 8, 2024 08:10
@pavjacko pavjacko added the e2e label Mar 8, 2024
@pavjacko pavjacko marked this pull request as ready for review March 8, 2024 13:43
@pavjacko pavjacko merged commit 54682bf into release/1.0 Mar 10, 2024
3 checks passed
@pavjacko pavjacko deleted the feat/cli-updates-2 branch March 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants