Fix/app harness #1447
Merged
Fix/app harness #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiblaga89
requested changes
Mar 8, 2024
mihaiblaga89
approved these changes
Mar 8, 2024
pavjacko
requested changes
Mar 8, 2024
| if (typeof SplashScreen === 'function') { | ||
| SplashScreen(logDebug).hide(); | ||
| } else { | ||
| (SplashScreen as any)?.hide(); |
There was a problem hiding this comment.
@ElenaDiachenko this needs to redone as casting to any is a red flag
| export const addNotificationListeners = () => { | ||
| console.log('addNotificationListeners not supported on this platform'); | ||
| export const addNotificationListeners = (logDebug: (message: string) => void) => { | ||
| logDebug('addNotificationListeners not supported on this platform'); |
There was a problem hiding this comment.
instead of treating param as logDebug treat it as callback and add reusable type
export const addNotificationListeners = (callback: NotificationCallback) => {
type NotificationCallback = {
({ message: string }) => void
}
| } else { | ||
| (SplashScreen as any)?.hide(); | ||
| } | ||
| addNotificationListeners(logDebug); |
There was a problem hiding this comment.
with NotificationCallback (check comms below) you can make this generic:
addNotificationListeners(({message}) => logDebug(message));
GabrieleKaceviciute
requested changes
Mar 8, 2024
Merged
GabrieleKaceviciute
approved these changes
Mar 12, 2024
pauliusguzas
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Npm releases
n/a
NOTE:
test this PR following following: