Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webos white screen #1444

Merged
merged 8 commits into from Mar 8, 2024
Merged

Fix webos white screen #1444

merged 8 commits into from Mar 8, 2024

Conversation

mihaiblaga89
Copy link
Member

@mihaiblaga89 mihaiblaga89 commented Mar 6, 2024 •
edited

Description

Related issues

Npm releases

n/a

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 6, 2024
View reviewed changes
packages/core/src/system/exec.ts Outdated
let replacedString = string;
if (overrides?.length && replacedString?.replace) {
overrides.forEach((v) => {
const regEx = new RegExp(v, 'g');

Check failure

Code scanning / CodeQL

Regular expression injection High

This regular expression is constructed from a
environment variable
.
packages/core/src/context/contextProps.ts Outdated
if (Array.isArray(resultScheme) || typeof resultScheme !== 'object') {
return resultScheme;
}
const val = Object.assign(resultCommon || {}, resultPlatforms || {}, resultScheme);

Check warning

Code scanning / CodeQL

Prototype-polluting assignment Medium

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
packages/core/src/context/contextProps.ts Outdated
if (Array.isArray(resultPlatforms) || typeof resultPlatforms !== 'object') {
return resultPlatforms;
}
return Object.assign(resultCommon || {}, resultPlatforms);

Check warning

Code scanning / CodeQL

Prototype-polluting assignment Medium

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
packages/app-harness/tst/usr/palm/applications/com.domain.app/index.html Fixed Show fixed Hide fixed
packages/core/src/context/contextProps.ts Outdated
logError('getPlatformProjectDir not available without specific engine');
return null;
}
return path.join(getAppFolder(c), c.runtime.engine.projectDirName || '');

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
packages/core/src/context/contextProps.ts Outdated
logError('getPlatformProjectDir not available without specific engine');
return null;
}
return path.join(getAppFolder(c), c.runtime.engine.projectDirName || '');

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
This path concatenation which depends on
library input
is later used in a
shell command
.
@mihaiblaga89 mihaiblaga89 changed the base branch from main to release/1.0 March 7, 2024 12:42
@mihaiblaga89 mihaiblaga89 marked this pull request as ready for review March 8, 2024 07:48
@pauliusguzas pauliusguzas self-requested a review March 8, 2024 11:26
pauliusguzas
pauliusguzas requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc.12: all white blank screen
this PR: all black blank screen

so the issue isn't actually fixed

@pauliusguzas pauliusguzas self-requested a review March 8, 2024 11:51
pauliusguzas
pauliusguzas approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed for webos

@pauliusguzas pauliusguzas added e2e and removed e2e labels Mar 8, 2024
@pavjacko pavjacko merged commit bf566a4 into release/1.0 Mar 8, 2024
1 check passed
@pavjacko pavjacko deleted the fix/webos_white_screen branch March 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavjacko pavjacko pavjacko approved these changes

@pauliusguzas pauliusguzas pauliusguzas approved these changes

Assignees
No one assigned
Labels
e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mihaiblaga89 @pavjacko @pauliusguzas