Add back INJECT_PLUGIN_PATHS, INJECT_POST_INSTALL #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mihaiblaga89 how is this testable? |
pavjacko
requested changes
Mar 8, 2024
There was a problem hiding this comment.
@mihaiblaga89 we need proper test case in app-harness. any plugin which can take advantage of this will do
pauliusguzas
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testcase:
npx rnv run -p ios -s debug-static-podsshould succeed. For this scheme there are 2 extra plugins added, react-native-firebase and react-native-photo-editor. Both need the injections to work. The build will fail otherwise.Related issues
Npm releases
n/a