Rename MainActivity files, add test cases to set plugins, and fix to copy build folders #1439

ElenaDiachenko · 2024-03-04T20:29:36Z

Description

Rename MainActivity_java to MainActivity_kt
add a test case to test AndroidManifest_xml overrides in app-harness ( "react-native-photo-editor" plugin)
fix copying of builds folder from external pluginTemplates
add a test case to test the override of builds folder from an external package
allow the androidManifest attribute to be set to false:

 "platforms": {
        "android": {
            "templateAndroid": {
                "AndroidManifest_xml": {
                    "tag": "manifest",
                    "android:name": "",
                    "children": [
                        {
                            "tag": "application",
                            "android:name": ".MainApplication",
                            "android:largeHeap": false,
                            "children": []
                        }
                    ]
                }
            }
        }
    },

Related issues

n/a

Npm releases

n/a

NOTE:
test this PR following following:

Release PRs Sync #1454

pauliusguzas · 2024-03-05T13:49:28Z

@ElenaDiachenko any way to test this?

ElenaDiachenko · 2024-03-05T14:16:33Z

@pauliusguzas
Check #1435. I added settings to app-harness/renative.json/plugins/"react-native-photo-editor"/android/templateAndroid/AndroidManifest_xml.

If you run android and check platformBuilds/harness_android/app/src/main/AndroidManifest.xml you will see these activities and uses-permission being injected.

pauliusguzas · 2024-03-05T17:39:52Z

@ElenaDiachenko I think we agreed that no testing will be done via code, test case on app-harness maybe should be added. cc @pavjacko @mihaiblaga89

packages/sdk-android/src/kotlinParser.ts

packages/app-harness/renative.json

packages/sdk-android/src/manifestParser.ts

GabrieleKaceviciute

can't run app-harness on androidwear and androidtv ->

app-harness git:(fix/androidManifest_generating) npx rnv run -p androidwear

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0-rc.12 | renative.org | 3/14/2024, 6:07:53 PM         │
│ $ npx rnv run -p androidwear                                    │
└─────────────────────────────────────────────────────────────────┘
info: Load engine: @rnv/engine-rn (./node_modules/@rnv/engine-rn)
info: Load engine: @rnv/engine-rn-tvos (./node_modules/@rnv/engine-rn-tvos)
info: Load engine: @rnv/engine-rn-next (./node_modules/@rnv/engine-rn-next)
info: Load engine: @rnv/engine-rn-web (./node_modules/@rnv/engine-rn-web)
info: Load engine: @rnv/engine-rn-electron (./node_modules/@rnv/engine-rn-electron)
info: Current engine: engine-rn (../engine-rn)
task: ○ run [1]
task: ○ configure [1]
task: ○ platform configure [1]
task: ○ project configure [1]
task: ○ workspace configure [1]
task: ✔ workspace configure [1]
task: ○ install [1]
task: ✔ install [1]
task: ○ install [2]
task: ✔ install [2]
task: ○ app configure [1]
info: Current app config: harness
task: ✔ app configure [1]
info: Plugin overrides disabled for: react-native-gesture-handler with disablePluginTemplateOverrides. SKIPPING
info: ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js overriden by: ../rnv/pluginTemplates/@react-native-community/cli-platform-ios/overrides@11.3.7.json
info: Plugin overrides disabled for: next with disablePluginTemplateOverrides. SKIPPING
info: ../../node_modules/rn-fetch-blob overriden by: /@flexn/plugins/pluginTemplates/rn-fetch-blob/overrides
info: ../../node_modules/react-native-photo-editor overriden by: /@flexn/plugins/pluginTemplates/react-native-photo-editor/overrides
info: Plugin overrides disabled for: react-native-permissions with disablePluginTemplateOverrides. SKIPPING
task: ✔ project configure [1]
info: Current Build Scheme: debug
task: ○ install [3]
task: ✔ install [3]
task: ✔ platform configure [1]
info: Found custom assetFolderPlatform: android. Will use it instead of deafult androidwear
info: Found custom assetSources at ../../node_modules/@flexn/assets-renative-outline/assets/android. Will be used to generate assets.
task: ✔ configure [1]
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
✔ Executing: /Users/gabriele/Library/Android/sdk/emulator/emulator -list-avds
✔ Waiting for emulator to boot...
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm size
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm density
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop
task: ○ start [1]

Dev server running at: http://0.0.0.0:8089/index.bundle?platform=android

task: ✔ start [1]
⠼ Waiting for bundler to finish...
  WARNING: You should run npx react-native@latest to ensure you're always using the most current version of the CLI. NPX has cached version (0.73.4) != current release (0.73.6)

⠏ Waiting for bundler to finish...warn Package rn-fetch-blob contains invalid configuration: "dependency.hooks" is not allowed. Please verify it's properly linked using "npx react-native config" command and contact the package maintainers about this.
warn =================================================================================================
warn From React Native 0.73, your project's Metro config should extend '@react-native/metro-config'
warn or it will fail to build. Please copy the template at:
warn https://github.com/facebook/react-native/blob/main/packages/react-native/template/metro.config.js
warn This warning will be removed in future (https://github.com/facebook/metro/issues/1018).
warn =================================================================================================
info Welcome to React Native v0.73
info Starting dev server on port 8089...

                        ▒▒▓▓▓▓▒▒
                     ▒▓▓▓▒▒░░▒▒▓▓▓▒
                  ▒▓▓▓▓░░░▒▒▒▒░░░▓▓▓▓▒
                 ▓▓▒▒▒▓▓▓▓▓▓▓▓▓▓▓▓▒▒▒▓▓
                 ▓▓░░░░░▒▓▓▓▓▓▓▒░░░░░▓▓
                 ▓▓░░▓▓▒░░░▒▒░░░▒▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▒▒▒▒▓▓▓▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▓▓▓▓▓▓▓▓▒░░▓▓
                 ▓▓▒░░▒▒▓▓▓▓▓▓▓▓▒░░░▒▓▓
                  ▒▓▓▓▒░░░▒▓▓▒░░░▒▓▓▓▒
                     ▒▓▓▓▒░░░░▒▓▓▓▒
                        ▒▒▓▓▓▓▒▒


                Welcome to Metro v0.80.5
              Fast - Scalable - Integrated


⠙ Waiting for bundler to finish...info React Native v0.73.6 is now available (your project is running on v0.73.4).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.73.6
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.73.6
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos".
✔ Waiting for bundler to finish...
info: ANDROID PACKAGE STARTING...
✔ Executing: react-native bundle --platform android --dev false --assets-dest /Users/gabriele/Desktop/tests/renative/packages/app-harness/platformBuilds/harness_androidwear/app/src/main/res --entry-file index.js --bundle-output /Users/gabriele/Desktop/tests/renative/packages/app-harness/platformBuilds/harness_androidwear/app/src/main/assets/index.bundle --config=metro.config.js
info: ANDROID PACKAGE FINISHED

  WARNING: You should run npx react-native@latest to ensure you're always using the most current version of the CLI. NPX has cached version (0.73.4) != current release (0.73.6)

warn Package rn-fetch-blob contains invalid configuration: "dependency.hooks" is not allowed. Please verify it's properly linked using "npx react-native config" command and contact the package maintainers about this.
info Building the app...

> Configure project :react-native-firebase_app
:react-native-firebase_app package.json found at /Users/gabriele/Desktop/tests/renative/node_modules/@react-native-firebase/app/package.json
:react-native-firebase_app:firebase.bom using default value: 32.5.0
:react-native-firebase_app:play.play-services-auth using default value: 20.7.0
:react-native-firebase_app package.json found at /Users/gabriele/Desktop/tests/renative/node_modules/@react-native-firebase/app/package.json
:react-native-firebase_app:version set from package.json: 18.6.1 (18,6,1 - 18006001)
:react-native-firebase_app:android.compileSdk using custom value: 34
:react-native-firebase_app:android.targetSdk using custom value: 34
:react-native-firebase_app:android.minSdk using custom value: 26
:react-native-firebase_app:reactNativeAndroidDir /Users/gabriele/Desktop/tests/renative/node_modules/react-native/android
WARNING: The specified Android SDK Build Tools version (28.0.2) is ignored, as it is below the minimum supported version (33.0.1) for Android Gradle Plugin 8.1.1.
Android SDK Build Tools 33.0.1 will be used.
To suppress this warning, remove "buildToolsVersion '28.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':react-native-photo-editor:bundleLibCompileToJarDebug'.
> Could not create task ':react-native-photo-editor:compileDebugJavaWithJavac'.
   > In order to compile Java 9+ source, please set compileSdkVersion to 30 or above

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 3s
5 actionable tasks: 5 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

error Failed to build the app.
Error: Command failed with exit code 1: ./gradlew app:installDebug -x lint -PreactNativeDevServerPort=8089
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at Function.module.exports.sync (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:194:17)
    at build (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/buildAndroid/index.js:68:22)
    at runOnSpecificDevice (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:220:33)
    at buildAndRun (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:182:12)
    at Object.runAndroid [as func] (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:115:10)
    at Command.handleAction (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:118:23)
    at Command.listener [as _actionHandler] (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:482:17)
    at /Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1283:65
    at Command._chainOrCall (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1177:12)
    at Command._parseCommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1283:27)
    at /Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1081:27
    at Command._chainOrCall (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1177:12)
    at Command._dispatchSubcommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1077:23)
    at Command._parseCommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1248:19)
    at Command.parse (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:909:10)
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 3/14/2024, 6:08:23 PM | rnv@1.0.0-rc.12             │
│ $ npx rnv run -p androidwear                                    │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/app-harness@1.0.0-rc.12                           │
│ Workspace: rnv                                                  │
│ Platform (-p): androidwear                                      │
│ Engine: engine-rn                                               │
│ Template: @rnv/template-starter@1.0.0-rc.12                     │
│ App Config (-c): harness                                        │
│ Build Scheme (-s): debug                                        │
│ Target (-t): Wear_OS_Square_API_30                              │
│ Supported Platforms: androidwear                                │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:30s:62ms                                   │
│ error: ⨯ ○ run: COMMAND:

npx react-native run-android --mode=Debug --no-packager --main-activity=MainActivity --deviceId=emulator-5554

FAILED with ERROR:

Error: Command failed with exit code 1: npx react-native run-android --mode=Debug --no-packager --main-activity=MainActivity --deviceId=emulator-5554
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


│ Project location: ./platformBuilds/harness_androidwear          │
└─────────────────────────────────────────────────────────────────┘
➜  app-harness git:(fix/androidManifest_generating)

androidtv ->

➜  app-harness git:(fix/androidManifest_generating) npx rnv run -p androidtv

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0-rc.12 | renative.org | 3/14/2024, 6:11:21 PM         │
│ $ npx rnv run -p androidtv                                      │
└─────────────────────────────────────────────────────────────────┘
info: Load engine: @rnv/engine-rn (./node_modules/@rnv/engine-rn)
info: Load engine: @rnv/engine-rn-tvos (./node_modules/@rnv/engine-rn-tvos)
info: Load engine: @rnv/engine-rn-next (./node_modules/@rnv/engine-rn-next)
info: Load engine: @rnv/engine-rn-web (./node_modules/@rnv/engine-rn-web)
info: Load engine: @rnv/engine-rn-electron (./node_modules/@rnv/engine-rn-electron)
info: Current engine: engine-rn-tvos (../engine-rn-tvos)
task: ○ run [1]
task: ○ configure [1]
task: ○ platform configure [1]
task: ○ project configure [1]
task: ○ workspace configure [1]
task: ✔ workspace configure [1]
task: ○ install [1]
task: ✔ install [1]
task: ○ install [2]
task: ✔ install [2]
task: ○ app configure [1]
info: Current app config: harness
task: ✔ app configure [1]
info: Plugin overrides disabled for: react-native-gesture-handler with disablePluginTemplateOverrides. SKIPPING
info: ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js overriden by: ../rnv/pluginTemplates/@react-native-community/cli-platform-ios/overrides@11.3.7.json
info: Plugin overrides disabled for: next with disablePluginTemplateOverrides. SKIPPING
info: ../../node_modules/rn-fetch-blob overriden by: /@flexn/plugins/pluginTemplates/rn-fetch-blob/overrides
info: ../../node_modules/react-native-photo-editor overriden by: /@flexn/plugins/pluginTemplates/react-native-photo-editor/overrides
info: Plugin overrides disabled for: react-native-permissions with disablePluginTemplateOverrides. SKIPPING
task: ✔ project configure [1]
info: Current Build Scheme: debug
task: ○ install [3]
task: ✔ install [3]
task: ✔ platform configure [1]
info: Found custom assetFolderPlatform: android. Will use it instead of deafult androidtv
info: Found custom assetSources at ../../node_modules/@flexn/assets-renative-outline/assets/android. Will be used to generate assets.
task: ✔ configure [1]
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
✔ Executing: /Users/gabriele/Library/Android/sdk/emulator/emulator -list-avds
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
✔ Waiting for emulator to boot...
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm size
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm density
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop
info: ✔ Found active emulator! emulator-5554. Will use it
task: ○ start [1]

Dev server running at: http://0.0.0.0:8084/index.bundle?platform=android

task: ✔ start [1]
⠙ Waiting for bundler to finish...warn Package rn-fetch-blob contains invalid configuration: "dependency.hooks" is not allowed. Please verify it's properly linked using "npx react-native config" command and contact the package maintainers about this.
warn =================================================================================================
warn From React Native 0.73, your project's Metro config should extend '@react-native/metro-config'
warn or it will fail to build. Please copy the template at:
warn https://github.com/facebook/react-native/blob/main/packages/react-native/template/metro.config.js
warn This warning will be removed in future (https://github.com/facebook/metro/issues/1018).
warn =================================================================================================
info Welcome to React Native v0.73
info Starting dev server on port 8084...

                        ▒▒▓▓▓▓▒▒
                     ▒▓▓▓▒▒░░▒▒▓▓▓▒
                  ▒▓▓▓▓░░░▒▒▒▒░░░▓▓▓▓▒
                 ▓▓▒▒▒▓▓▓▓▓▓▓▓▓▓▓▓▒▒▒▓▓
                 ▓▓░░░░░▒▓▓▓▓▓▓▒░░░░░▓▓
                 ▓▓░░▓▓▒░░░▒▒░░░▒▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▒▒▒▒▓▓▓▓▒░░▓▓
                 ▓▓░░▓▓▓▓▓▓▓▓▓▓▓▓▓▒░░▓▓
                 ▓▓▒░░▒▒▓▓▓▓▓▓▓▓▒░░░▒▓▓
                  ▒▓▓▓▒░░░▒▓▓▒░░░▒▓▓▓▒
                     ▒▓▓▓▒░░░░▒▓▓▓▒
                        ▒▒▓▓▓▓▒▒


                Welcome to Metro v0.80.5
              Fast - Scalable - Integrated


⠼ Waiting for bundler to finish...info React Native v0.73.6 is now available (your project is running on v0.73.4).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.73.6
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.73.6
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos".
✔ Waiting for bundler to finish...

  WARNING: You should run npx react-native@latest to ensure you're always using the most current version of the CLI. NPX has cached version (0.73.4) != current release (0.73.6)

warn Package rn-fetch-blob contains invalid configuration: "dependency.hooks" is not allowed. Please verify it's properly linked using "npx react-native config" command and contact the package maintainers about this.
info Building the app...

> Configure project :react-native-firebase_app
:react-native-firebase_app package.json found at /Users/gabriele/Desktop/tests/renative/node_modules/@react-native-firebase/app/package.json
:react-native-firebase_app:firebase.bom using default value: 32.5.0
:react-native-firebase_app:play.play-services-auth using default value: 20.7.0
:react-native-firebase_app package.json found at /Users/gabriele/Desktop/tests/renative/node_modules/@react-native-firebase/app/package.json
:react-native-firebase_app:version set from package.json: 18.6.1 (18,6,1 - 18006001)
:react-native-firebase_app:android.compileSdk using custom value: 34
:react-native-firebase_app:android.targetSdk using custom value: 34
:react-native-firebase_app:android.minSdk using custom value: 26
:react-native-firebase_app:reactNativeAndroidDir /Users/gabriele/Desktop/tests/renative/node_modules/react-native/android
WARNING: The specified Android SDK Build Tools version (28.0.2) is ignored, as it is below the minimum supported version (33.0.1) for Android Gradle Plugin 8.1.1.
Android SDK Build Tools 33.0.1 will be used.
To suppress this warning, remove "buildToolsVersion '28.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':react-native-photo-editor:bundleLibCompileToJarDebug'.
> Could not create task ':react-native-photo-editor:compileDebugJavaWithJavac'.
   > In order to compile Java 9+ source, please set compileSdkVersion to 30 or above

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 4s
5 actionable tasks: 5 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

error Failed to build the app.
Error: Command failed with exit code 1: ./gradlew app:installDebug -x lint -PreactNativeDevServerPort=8084
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at Function.module.exports.sync (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:194:17)
    at build (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/buildAndroid/index.js:68:22)
    at runOnSpecificDevice (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:220:33)
    at buildAndRun (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:182:12)
    at Object.runAndroid [as func] (/Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:115:10)
    at Command.handleAction (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:118:23)
    at Command.listener [as _actionHandler] (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:482:17)
    at /Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1283:65
    at Command._chainOrCall (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1177:12)
    at Command._parseCommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1283:27)
    at /Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1081:27
    at Command._chainOrCall (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1177:12)
    at Command._dispatchSubcommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1077:23)
    at Command._parseCommand (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:1248:19)
    at Command.parse (/Users/gabriele/Desktop/tests/renative/node_modules/react-native/node_modules/commander/lib/command.js:909:10)
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 3/14/2024, 6:11:40 PM | rnv@1.0.0-rc.12             │
│ $ npx rnv run -p androidtv                                      │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/app-harness@1.0.0-rc.12                           │
│ Workspace: rnv                                                  │
│ Platform (-p): androidtv                                        │
│ Engine: engine-rn-tvos                                          │
│ Template: @rnv/template-starter@1.0.0-rc.12                     │
│ App Config (-c): harness                                        │
│ Build Scheme (-s): debug                                        │
│ Target (-t): Television_1080p_API_31                            │
│ Supported Platforms: androidtv                                  │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:19s:101ms                                  │
│ info: ✔ Found active emulator! emulator-5554. Will use it
│ error: ⨯ ○ run: COMMAND:

npx react-native run-android --mode=Debug --no-packager --main-activity=SplashActivity --deviceId=emulator-5554

FAILED with ERROR:

Error: Command failed with exit code 1: npx react-native run-android --mode=Debug --no-packager --main-activity=SplashActivity --deviceId=emulator-5554
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


│ Project location: ./platformBuilds/harness_androidtv            │
└─────────────────────────────────────────────────────────────────┘
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 3/14/2024, 6:11:40 PM | rnv@1.0.0-rc.12             │
│ $ npx rnv run -p androidtv                                      │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/app-harness@1.0.0-rc.12                           │
│ Workspace: rnv                                                  │
│ Platform (-p): androidtv                                        │
│ Engine: engine-rn-tvos                                          │
│ Template: @rnv/template-starter@1.0.0-rc.12                     │
│ App Config (-c): harness                                        │
│ Build Scheme (-s): debug                                        │
│ Target (-t): Television_1080p_API_31                            │
│ Supported Platforms: androidtv                                  │
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:19s:117ms                                  │
│ info: ✔ Found active emulator! emulator-5554. Will use it
│ error: ⨯ ○ run: COMMAND:

npx react-native run-android --mode=Debug --no-packager --main-activity=SplashActivity --deviceId=emulator-5554

FAILED with ERROR:

Error: Command failed with exit code 1: npx react-native run-android --mode=Debug --no-packager --main-activity=SplashActivity --deviceId=emulator-5554
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


│ error: ⨯ ○ run: COMMAND:

node /Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/local-cli/cli.js start --port 8084 --no-interactive --config=metro.config.js

FAILED with ERROR:

Error: Command was killed with SIGTERM (Termination): node /Users/gabriele/Desktop/tests/renative/node_modules/react-native-tvos/local-cli/cli.js start --port 8084 --no-interactive --config=metro.config.js
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


│ Project location: ./platformBuilds/harness_androidtv            │
└─────────────────────────────────────────────────────────────────┘
➜  app-harness git:(fix/androidManifest_generating)

…from external pluginTemplatess

ElenaDiachenko self-assigned this Mar 4, 2024

ElenaDiachenko added this to the 1.0 milestone Mar 4, 2024

ElenaDiachenko added the e2e label Mar 4, 2024

mihaiblaga89 requested changes Mar 6, 2024

View reviewed changes

packages/sdk-android/src/kotlinParser.ts Outdated Show resolved Hide resolved

mihaiblaga89 changed the title ~~Fix/android manifest generating~~ Rename MainActivity_java to MainActivity_kt Mar 7, 2024

pavjacko requested changes Mar 8, 2024

View reviewed changes

packages/sdk-android/src/kotlinParser.ts Outdated Show resolved Hide resolved

packages/app-harness/renative.json Outdated Show resolved Hide resolved

packages/sdk-android/src/manifestParser.ts Outdated Show resolved Hide resolved

pavjacko mentioned this pull request Mar 11, 2024

Release PRs Sync #1454

Merged

add PhotoEditor for android

137df5b

mihaiblaga89 changed the base branch from release/1.0 to chore/release_sync_2 March 13, 2024 08:10

ElenaDiachenko added 4 commits March 13, 2024 14:08

fix fetchAndMovePhoto

d1908cf

add react-native-photo-editor overrides

365748e

remove unnecessary changes

1adbe81

clean code

15bd3c9

GabrieleKaceviciute self-requested a review March 14, 2024 16:09

GabrieleKaceviciute requested changes Mar 14, 2024

View reviewed changes

add react-native-photo-editor for ios + fix copying of builds folder …

fbc09db

…from external pluginTemplatess

ElenaDiachenko changed the title ~~Rename MainActivity_java to MainActivity_kt~~ Rename MainActivity files, add test cases to set plugins, and fix to copy build folders Mar 14, 2024

GabrieleKaceviciute approved these changes Mar 15, 2024

View reviewed changes

Base automatically changed from chore/release_sync_2 to release/1.0 March 15, 2024 20:47

pavjacko approved these changes Mar 15, 2024

View reviewed changes

pavjacko merged commit f9d335d into release/1.0 Mar 15, 2024
1 check passed

pavjacko deleted the fix/androidManifest_generating branch March 15, 2024 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename MainActivity files, add test cases to set plugins, and fix to copy build folders #1439

Rename MainActivity files, add test cases to set plugins, and fix to copy build folders #1439

ElenaDiachenko commented Mar 4, 2024 •

edited

pauliusguzas commented Mar 5, 2024

ElenaDiachenko commented Mar 5, 2024

pauliusguzas commented Mar 5, 2024

GabrieleKaceviciute left a comment

Rename MainActivity files, add test cases to set plugins, and fix to copy build folders #1439

Rename MainActivity files, add test cases to set plugins, and fix to copy build folders #1439

Conversation

ElenaDiachenko commented Mar 4, 2024 • edited

Description

Related issues

Npm releases

pauliusguzas commented Mar 5, 2024

ElenaDiachenko commented Mar 5, 2024

pauliusguzas commented Mar 5, 2024

GabrieleKaceviciute left a comment

Choose a reason for hiding this comment

ElenaDiachenko commented Mar 4, 2024 •

edited