Skip to content

Commit

Permalink
Merge pull request #1470 from flexn-io/fix_ios
Browse files Browse the repository at this point in the history
fix schemeTarget for ios
  • Loading branch information
pavjacko committed Mar 15, 2024
2 parents 3cbd336 + 58a4129 commit abd41cb
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions packages/sdk-apple/src/runner.ts
Expand Up @@ -217,7 +217,7 @@ export const runXcodeProject = async (runDeviceArguments?: string) => {
logDefault('runXcodeProject', `targetArgs:${runDeviceArguments}`);

const appPath = getAppFolder();
const schemeTarget = getConfigProp('schemeTarget') || 'RNVApp';
const schemeTarget = getConfigProp('schemeTarget') || _getDefaultSchemeTarget(c.platform!);
const runScheme = getConfigProp('runScheme') || 'Debug';
const bundleIsDev = getConfigProp('bundleIsDev') === true;
const bundleAssets = getConfigProp('bundleAssets') === true;
Expand Down Expand Up @@ -463,7 +463,7 @@ export const buildXcodeProject = async () => {

const appFolderName = getAppFolderName();
const runScheme = getConfigProp('runScheme', 'Debug');
const schemeTarget = getConfigProp('schemeTarget') || 'RNVApp';
const schemeTarget = getConfigProp('schemeTarget') || _getDefaultSchemeTarget(c.platform!);

let destinationPlatform = '';
switch (c.platform) {
Expand Down Expand Up @@ -567,7 +567,8 @@ const archiveXcodeProject = () => {
const { platform } = c;

const appFolderName = getAppFolderName();
const schemeTarget = getConfigProp('schemeTarget', 'RNVApp');
const schemeTarget = getConfigProp('schemeTarget', _getDefaultSchemeTarget(c.platform!));

const runScheme = getConfigProp('runScheme', 'Debug');
let sdk = getConfigProp('sdk');
if (!sdk) {
Expand Down Expand Up @@ -836,3 +837,5 @@ export const configureXcodeProject = async () => {
await parseXcodeProject();
return true;
};

const _getDefaultSchemeTarget = (platform: string) => (platform === 'ios' ? 'RNVApp' : 'RNVApp-tvOS');

0 comments on commit abd41cb

Please sign in to comment.