UI – Queries table: Fix issues with filter/sorting, optimize render behavior

[jacobshandling]

Addresses #18881 and #18858

• Fix the bugs, memoize various props to optimize table rendering

QA

In addition to the bugs outlined in the addressed issue, this PR contains rendering optimizations. Please check these functionalities, which should be unaffected (and were so in my own testing) but should be double-checked:

• create query
• delete query
• empty state
• changing platform dropdown
• different sort orders
• delete query from table action
• results count change

Checklist for submitter

• Changes file added for user-visible changes in changes/
• Manual QA for all new/changed functionality

[RachelElysia]

Reviewer manually QAed:

• fixes Team queries filters are reset when additional action is taken on the page. #18881
• fixes Queries table re-renders prematurely on platform filter change #18858
• create query (tested team and global)
• delete query (tested team and global)
• empty state (tested team and global for empty search only, did not test empty start)
• changing platform dropdown
• different sort orders
• delete query from table action (tested top checkbox used to select and delete)

Only saw one cosmetic issue (see recording):

• results count change
  • All counts look like they matched in all the tests I did
  • Prevent wrong count from quickly flashing

https://www.loom.com/share/f2c9ebe9c8bb445d8765860083f5b4a5?sid=5e7d15c7-194e-4779-8ba2-65fdd83939c6

Let me know if you want me to approve and then you can iterate, or if you want fix the flashing wrong number on this PR.

[RachelElysia]

Love to hear all your insight from working on this later today.

[jacobshandling]

@RachelElysia, the update we tried with specifying platforms accessor name in the filters led to some strange rendering of empty states and associated failing of unit tests. I think we should leave the solution as it is now (using global, plus some comments and cleanup), and file an eng-initiated ticket for cleaning up TableContainer and Datatable. Some of that experimentation (though not all, I tried cleaning up other parts of TableContainer and it became too much scope creep) exists in the commit history here if you want to try it out and see what I mean.

[RachelElysia]

Thank you for all this!

I filed another bug for: Prevent wrong count from quickly flashing
#19090