Updating user now updates activity feed. #18962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sometimes did not update the activity feed and returned the un-updated user object.
lucasmrod
reviewed
May 14, 2024
| // Since we just modified the user and the changes may not have replicated to the read replica(s) yet, | ||
| // we must use the master to ensure we get the most up-to-date information. | ||
| ctxUsePrimary := ctxdb.RequirePrimary(ctx, true) | ||
| user, err = svc.User(ctxUsePrimary, userID) |
There was a problem hiding this comment.
Another approach is for svc.ds.SaveUser itself (and svc.saveUser(ctx, user)) to return the updated user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18766
Fixed a bug where updating user via
/api/v1/fleet/users/:idendpoint sometimes did not update the activity feed and returned the un-updated user object.You must use a DB configuration with a replica to reproduce the issue.
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.