-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Software installers: backend cleanup tasks part 1 #18955
Conversation
err = json.NewDecoder(res.Body).Decode(&getDeviceSw) | ||
require.NoError(t, err) | ||
require.Len(t, getDeviceSw.Software, 1) // bar only | ||
require.Equal(t, getDeviceSw.Software[0].Name, "bar") | ||
require.Len(t, getDeviceSw.Software[0].InstalledVersions, 1) | ||
} | ||
|
||
func (s *integrationEnterpriseTestSuite) TestSoftwareInstallerUploadDownloadAndDelete() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the changes in this file are just test cases and helpers moved from the MDM suite to this Enterprise suite.
@@ -8466,613 +8459,3 @@ func (s *integrationMDMTestSuite) TestIsServerBitlockerStatus() { | |||
require.NotNil(t, hr.Host.MDM.OSSettings.DiskEncryption.Status) | |||
require.Equal(t, fleet.DiskEncryptionEnforcing, *hr.Host.MDM.OSSettings.DiskEncryption.Status) | |||
} | |||
|
|||
func (s *integrationMDMTestSuite) TestSoftwareInstallerUploadDownloadAndDelete() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to Enterprise test suite.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-software-installers #18955 +/- ##
===========================================================
Coverage ? 66.75%
===========================================================
Files ? 898
Lines ? 110537
Branches ? 0
===========================================================
Hits ? 73792
Misses ? 30766
Partials ? 5979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ 🧹 ✨
#18677
Checklist for submitter
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)