Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software installers: backend cleanup tasks part 1 #18955

Merged
merged 5 commits into from
May 14, 2024

Conversation

mna
Copy link
Member

@mna mna commented May 13, 2024

#18677

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests

err = json.NewDecoder(res.Body).Decode(&getDeviceSw)
require.NoError(t, err)
require.Len(t, getDeviceSw.Software, 1) // bar only
require.Equal(t, getDeviceSw.Software[0].Name, "bar")
require.Len(t, getDeviceSw.Software[0].InstalledVersions, 1)
}

func (s *integrationEnterpriseTestSuite) TestSoftwareInstallerUploadDownloadAndDelete() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes in this file are just test cases and helpers moved from the MDM suite to this Enterprise suite.

@@ -8466,613 +8459,3 @@ func (s *integrationMDMTestSuite) TestIsServerBitlockerStatus() {
require.NotNil(t, hr.Host.MDM.OSSettings.DiskEncryption.Status)
require.Equal(t, fleet.DiskEncryptionEnforcing, *hr.Host.MDM.OSSettings.DiskEncryption.Status)
}

func (s *integrationMDMTestSuite) TestSoftwareInstallerUploadDownloadAndDelete() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Enterprise test suite.

@mna mna marked this pull request as ready for review May 13, 2024 18:16
@mna mna requested a review from a team as a code owner May 13, 2024 18:16
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 94.91525% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat-software-installers@0debd18). Click here to learn what that means.

❗ Current head b58d473 differs from pull request most recent head 09b06d9. Consider uploading reports for the commit 09b06d9 to get more accurate results

Files Patch % Lines
server/datastore/mysql/software_installers.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feat-software-installers   #18955   +/-   ##
===========================================================
  Coverage                            ?   66.75%           
===========================================================
  Files                               ?      898           
  Lines                               ?   110537           
  Branches                            ?        0           
===========================================================
  Hits                                ?    73792           
  Misses                              ?    30766           
  Partials                            ?     5979           
Flag Coverage Δ
backend 66.75% <94.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🧹 ✨

@mna mna merged commit 3579e5a into feat-software-installers May 14, 2024
12 checks passed
@mna mna deleted the mna-18677-cleanup-tasks-part1 branch May 14, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants